Fix VM plugins

[Wild-W]

closes #2831

This pull request fixes VM.OnCompileFunctionParam and its test case.

I had the StyLua autoformatter on so some formatting changes were made to compiler.lua. I'm not sure if this is a problem, as I had just assumed this project was StyLua compliant and I was expected to have the formatter running.

[CppCXY]

I had the StyLua autoformatter on so some formatting changes were made to compiler.lua. I'm not sure if this is a problem, as I had just assumed this project was StyLua compliant and I was expected to have the formatter running.

This assumption is incorrect. We do not use StyLua. Do not use a formatter to make unnecessary changes. You can use range formatting on the code you wrote (if your plugin supports it). From the formatting results, it seems you didn't use StyLua but rather the built-in formatting functionality of LuaLS, as these alignments are unique to LuaLS.

[tomlau10]

And when "fixing up" those unnecessary changes, please use amend/squash/fixup & force push. (or just mix reset everything and recommit from the start)

Otherwise if you just create another commit say fix style issue, this will DOUBLE THE DAMAGE as changes are made TWICE and will leave 2 times changes in the git history. This will greatly impact future usage of git blame (when tracing which changes cause problems while debugging) ☹️

---

Just a tip for quickly squashing the fixup commit: 😄

• I use git fork which has a very user-friendly ui: https://git-fork.com/
• now fix style issue and make a temp commit say fixup
• then interactive rebase on the parent commit of your pr
  • drag you fixup commit just above your first commit, we are going to combine them
  • change its action to fixup (which is same as squash, except without combining the commit msg)
  • start rebase
• done 👍 (and should recheck whole the changes again)

[Wild-W]

And when "fixing up" those unnecessary changes, please use amend/squash/fixup & force push. (or just mix reset everything and recommit from the start)

Otherwise if you just create another commit say fix style issue, this will DOUBLE THE DAMAGE as changes are made TWICE and will leave 2 times changes in the git history. This will greatly impact future usage of git blame (when tracing which changes cause problems while debugging) ☹️

Just a tip for quickly squashing the fixup commit: 😄

• I use git fork which has a very user-friendly ui: https://git-fork.com/

• now fix style issue and make a temp commit say fixup

• then interactive rebase on the parent commit of your pr

  • drag you fixup commit just above your first commit, we are going to combine them
  • change its action to fixup (which is same as squash, except without combining the commit msg)
  • start rebase

• done 👍 (and should recheck whole the changes again)

Thanks for the tips. I just force reset and recommitted, though your suggestions sound a fair bit more robust. 😄

[Wild-W]

Oops! I just noticed there were a couple unnecessary formats in plugin.lua too. Should be all good now.

[sumneko]

Thank you!