Merge pull request containers#9094 from rhatdan/mount

Pass DefaultMountsFile to podman build
Luap99 · Jan 26, 2021 · 79565d1 · 79565d1
2 parents 6ba8819 + 97f5e94
commit 79565d1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/cmd/podman/images/build.go b/cmd/podman/images/build.go
@@ -423,10 +423,10 @@ func buildFlagsWrapperToOptions(c *cobra.Command, contextDir string, flags *buil
 			Ulimit:       flags.Ulimit,
 			Volumes:      flags.Volumes,
 		},
-		Compression:      compression,
-		ConfigureNetwork: networkPolicy,
-		ContextDirectory: contextDir,
-		//		DefaultMountsFilePath:   FIXME: this requires global flags to be working!
+		Compression:             compression,
+		ConfigureNetwork:        networkPolicy,
+		ContextDirectory:        contextDir,
+		DefaultMountsFilePath:   containerConfig.Containers.DefaultMountsFile,
 		Devices:                 flags.Devices,
 		DropCapabilities:        flags.CapDrop,
 		Err:                     stderr,

diff --git a/test/e2e/run_test.go b/test/e2e/run_test.go
@@ -669,7 +669,7 @@ USER bin`
 	})
 
 	It("podman run with secrets", func() {
-		SkipIfRemote("--default-mount-file option is not supported in podman-remote")
+		SkipIfRemote("--default-mounts-file option is not supported in podman-remote")
 		containersDir := filepath.Join(podmanTest.TempDir, "containers")
 		err := os.MkdirAll(containersDir, 0755)
 		Expect(err).To(BeNil())

diff --git a/test/system/070-build.bats b/test/system/070-build.bats
@@ -188,8 +188,7 @@ ADD mycmd /bin/mydefaultcmd
 RUN chmod 755 /bin/mydefaultcmd
 RUN chown 2:3 /bin/mydefaultcmd
 
-#FIXME FIXME FIXME: enable if/when 'podman build' passes mounts.conf to buildah
-#RUN $CAT_SECRET
+RUN $CAT_SECRET
 
 CMD ["/bin/mydefaultcmd","$s_echo"]
 EOF
@@ -201,8 +200,7 @@ EOF
     local iid="${lines[-1]}"
 
     # Make sure 'podman build' had the secret mounted
-    #FIXME FIXME: enable if/when 'podman build' passes mounts.conf to buildah
-    #is "$output" ".*$secret_contents.*" "podman build has /run/secrets mounted"
+    is "$output" ".*$secret_contents.*" "podman build has /run/secrets mounted"
 
     if is_remote; then
         ENVHOST=""