Lucas/refresh #27
Lucas/refresh #27
Conversation
Lucas-Bruder
force-pushed
the
lucas/refresh
branch
from
235f20b to
1d3b04d
Compare
|
@MicroJoe I could use some help getting this example to compile using new file structure (build systems are my weakness :) At the moment, its not able to find the led_strip header file |
|
I can look at my configuration on monday and help you migrate this to the new build system. Stay tuned. |
|
I think you should rename the
And then when you include the component in a project like I do you can just import it like this: #include "led_strip.h" |
|
I also noticed that my |
| @@ -363,7 +363,7 @@ bool led_strip_set_pixel_color(struct led_strip_t *led_strip, uint32_t pixel_num | |||
| return set_led_success; | |||
| } | |||
|
|
|||
| bool led_strip_set_pixel_rgb(struct led_strip_t *led_strip, uint32_t pixel_num, uint8_t red, uint8_t green, uint8_t blue) | |||
| bool led_strip_set_pixel_rgb(struct led_strip_t *led_strip, const uint32_t pixel_num, const uint8_t red, const uint8_t green, const uint8_t blue) | |||
There was a problem hiding this comment.
Why apply const to copied values? I think const keyword is only relevant when using pointers so that you tell the users you won't modify the value they pass. Const for uint32_t and other copied values seems pointless to me (because you already can't modify it).
| @@ -1,202 +0,0 @@ | |||
|
|
|||
Added const to function parameters
Removed rmt_interrupt_num
Changed file structure to allow this to be imported as component
Just looking for review right meow