Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF 18.2 #2998

Merged
merged 84 commits into from
Aug 22, 2024
Merged

LF 18.2 #2998

merged 84 commits into from
Aug 22, 2024

Conversation

jeremie-lucca
Copy link
Contributor

@jeremie-lucca jeremie-lucca commented Aug 2, 2024

Description

Actions required to update

Table sorted import

@forward '@lucca-front/scss/src/components/indexTableSorted';
@forward '@lucca-front/scss/src/components/tableSorted';

must be replaced by

@forward '@lucca-front/scss/src/components/tableSortable';

Users

userTileStyle mixin import was removed by default to save weight and replaced by a SCSS component. We suggest to replace the mixin import by importing User Tile component (Angular or HTML (🚧 Add link)) or fix it with the deprecated import:

@use "@lucca-front/ng/src/definitions/user/user-tile";

🚧 Snippet UI change
userPictureStyle & userPictureVars mixins import were removed for the same reason. We suggest to replace mixins import by importing Avatar (HTML) / User Picture (Angular) (🚧 Add link) component or fix it with the deprecated import:

@use "@lucca-front/ng/src/definitions/user/user-picture";

Select optionKey

On all classes that extend ALuCoreSelectApiDirective, apps have to apps have to implement optionKey method:

class MyDirective extends ALuCoreSelectApiDirective {
	protected override optionKey = (option: T) => option.id;
}

Divider UI spacings

Divider vertical spacing was reduced from 1.5rem to 0.25rem to fit with Figma component.
We suggest to edit margins on divider's surrounding components, but if you need to quickly upgrade, it's possible to override divider margin to avoid UI breakings:

:root {
	--components-divider-margin: var(--pr-t-spacings-300);
}

🤖 Schematics

🎉 Features

🎨 Visual changes

🚑 Fixes

💬 Translations

🔨 Technical

📖 Documentation

💀 Deprecated

Colors variables

  • --colors-white-color / --colors-black-color colors Deprecated for black and white – Add neutral 0 #2921
  • --colors-white-color must be replaced by --palettes-neutral-0 or --pr-t-elevation-surface-raised depending if color refer to a surface or not.
  • --colors-black-color must be replaced by --palettes-neutral-900.

Table

  • .columnSticky is replaced by .stickyColumn (duplicate) columnSticky is deprecated #2928
  • .table-head-row-cell-sortableButton, .indexTable-head-row-cell-sortableButton, .table-head-row-cell.mod-sortable, .table-head-row-cell.sortedAscending & .table-head-row-cell.sortedDescending are replaced by a single tableSortable sub-component for Table and Index Table.

Users

  • User tile Mixin userTileStyle is replaced by HTML component import: @forward '@lucca-front/scss/src/components/userTile';
  • User picture / Avatar Mixin userPictureStyle & userPictureVars are replaced by HTML component import: @forward '@lucca-front/scss/src/components/userTile';

Utilities

  • .u-textLeft, .u-textCenter & .u-textRight are deprecated and replaced by .u-textAlignLeft, .u-textAlignCenter & .u-textAlignRight for consistency.

All information related to deprecated elements


jeremie-lucca and others added 30 commits June 19, 2024 16:43
Intl.NumberFormat: Add models, functions, pipe, directive and FormField input
@CCNET-iLucca
Copy link

Tests d'interfaces

* feat(dialog-routing): add dialog routing + story

* feat(dialog-routing): fix test

* feat(dialog-routing): update story

* feat(dialog-routing): fix wrongly edited routerLink in story
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

vvalentin-lucca and others added 12 commits August 16, 2024 14:44
* i18n-text-input

* feat(i18n-text-input): add model manipulation and CVA

* chore(i18n-text-input): better Intl implementation

* chore(i18n-text-input): remove cultureName from story

* chore(i18n-text-input): performance improvements

* rename component

* feat(multilanguage-input): new validator and check functions

* feat(multilanguage-input): support disabled state

* fix conflict

* chore(multilanguage-input): migrate structure to localize and add tooltip on button

* chore(multilanguage-input): put tooltip on button not icon

* fix optional classes

* fix lint error

* fix lint error

* remove size applied by default

* Icon size with mod-S

* Update docs/dialog.md

Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com>

* Update packages/ng/forms/multilanguage-input/multilanguage-input.component.scss

Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com>

---------

Co-authored-by: Flavien Normand <contact@flavien-normand.fr>
Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com>
Co-authored-by: Fabien Basmaison <144820795+fbasmaison-lucca@users.noreply.github.com>
* indexTable sortable

* linter

* step 2

* cleaning

* tableSorted > tableSortable

* cleaning legacy
* rewrite user tile as CSS component

* user tile NG package > css

* add documentation story

* update usertile ng component

* remove old user tile scss

* cleanup

---------

Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com>
* rewrite user tile as CSS component

* user tile NG package > css

* add documentation story

* update usertile ng component

* remove old user tile scss

* avatar basic refactor

* legacy

* Plug in ng component

* clean up

* clean up

* DOM rework

* remove default import + fix conflit issue

* Fix potential breaking with placeholder & put back inline-block display

* apply mixin on the right class
* feat(popover2): new input to remove a11y close button & enable that in i18n input

* add control to the story

---------

Co-authored-by: Flavien Normand <contact@flavien-normand.fr>
* chore(phone-number): init component

* feat(forms): new phone number input

#2882

* chore(phone-number-input): add missing prefix on pipe

* basic inputs UI

* feat(phone-number): add country and prefix search

* feat(phone-number): add country flags (TODO: align & spacing)

* chore(phone-number): make search case insensitive

* chore(phone-number): select displayer should show flag only

* UI

* a11y

* chore: fix CI build

* label englobant

* chore: imports fix

* chore(phone-number-input): switch to its own entry point

* chore(phone-number-input): remove unneeded try/catch block

* chore(phone-number-input): fix deep import

---------

Co-authored-by: Jérémie Biron <jbiron@luccasoftware.com>
Co-authored-by: Vincent Valentin <vvalentin@luccasoftware.com>
* inlineMessage-statusIcon

* portalContent

* cleanup

* stories

* feedbacks

* cleanup

* portalContent
@jeremie-lucca jeremie-lucca marked this pull request as ready for review August 22, 2024 13:45
@jeremie-lucca jeremie-lucca requested review from a team as code owners August 22, 2024 13:45
@LuccaIntegration
Copy link

@CCNET-iLucca
Copy link

Tests d'interfaces

@jeremie-lucca jeremie-lucca merged commit c32cb7b into master Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Documentation changes Requires a Prisme update 🔖🐛 FIX Bug / Visual fix (PR should target Master branch) 🔖✨ Feature New feature (even a very small one) 🔨 Technical Doesn't affect the output (refactor, dependencies update, cleaning, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants