Deemphasize MSRV by removing check and note from README #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI got broken by `clap` releasing `4.1.0` that bumped its MRSV to 1.64. Reading up on this again, I'm not sure how maintainers should best communicate MSRV for crates that have dependencies. I think saying "MSRV 1.60" in the README sets the expectation that this whole crate works with 1.60, which might not be the case due to dependencies. So... I left it in `Cargo.toml`, but otherwise this is not checked anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI got broken by
clapreleasing4.1.0that bumped its MRSV to 1.64. Reading up on this again, I'm not sure how maintainers should best communicate MSRV for crates that have dependencies. I think saying "MSRV 1.60" in the README sets the expectation that this whole crate works with 1.60, which might not be the case due to dependencies.So... I left it in
Cargo.toml, but otherwise this is not checked anymore.