Default to single-threaded tests for WebAssembly #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAssembly targets generally don't have support for spawning threads right now so this commit makes the library work a bit better by default on these targets. I'll note that wasm additionally doesn't have support for unwinding meaning that a failing test still aborts the whole process which also isn't great, but this can be a useful feature for projects that test both native and wasm where errors primarily come from native but CI might test wasm to ensure it still works, for example.
LukasKalbertodt
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAssembly targets generally don't have support for spawning threads right now so this commit makes the library work a bit better by default on these targets. I'll note that wasm additionally doesn't have support for unwinding meaning that a failing test still aborts the whole process which also isn't great, but this can be a useful feature for projects that test both native and wasm where errors primarily come from native but CI might test wasm to ensure it still works, for example.