Singletons should be Send, Sync and Clone
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a mutable reference.
LukeMathWalker
added a commit
that referenced
this pull request
Feb 14, 2023
* Failing test: Singletons must be Clone. * Write data structure that allows to insert new elements without using a mutable reference. * Draft Sync check * Fix handling of hyphens and "wrong" versions in the rustdoc module. * Add `tracing`. * Extract into function. * Implement error + rendering diagnostic. * Fix trait resolution. * Fix package search * Fix error reporting when dealing with references. * Clippy fixes * Remove unused parameter. * Fix more clippy lints * Fix test expected error message. * Fix Clone checking. Send seems to be broken. * Green. * Sync :check: * Implement Clone * Remove stray dbg. * Be careful with namespaces. * Add nice help message explaining why we care about those traits. * Update example * Add rudimentary tracing instrumentation. * More instrumentation. * Remove wasteful clone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few interesting side-quests to get this check implemented:
doc(html_root_url)attribute from all crates. tokio-rs/tracing#2384);tracingfor easier debuggability;Clonethat was adding a couple of seconds to the overall execution time.