OpenCV 4 only, GHC 9.2 support

[nh2]

In this PR I modernise opencv:

• Proper OpenCV 4 support.
  • Until now, opencv-extra code didn't seem to compile.
• GHC 9.2 support.
  • Single-line TemplateHaskell change in the DoE constructor.
• Newer library support.
  • Fixed breakage of the fancy example image generator, which used a copy-paste of a module from haskell-src-meta; it broke because its dependency haskell-src-exts evolved its API, see:
    • CHANGELOG for 1.22 does not mention breaking change of Asst/PAsst types haskell-suite/haskell-src-exts#446
    • Unable to install with GHC 8.6.5 cabal: 2.4.1.0 "Not in scope: data constructor `ClassA'" because of haskell-src-exts 1.22 update mihaimaruseac/hindent#562).
      The solution here is to use the upstreamed changes into haskell-src-meta which supports everything except * syntax for kinds (that syntax is now deprecated), so switching * to Type fixed that, see Support DataKinds bmillwood/haskell-src-meta#54 (comment).
• Add Cabal flag enable-nonfree to enable those modules that require the system OpenCV 4 to be compiled with the OPENCV_ENABLE_NONFREE option (most OpenCV installations lack this by default).
  This was previously enabled unconditionally, which worked fine for OpenCV 3 but not OpenCV 4.

FYI @ocharles

TODO

• Handle the fact that the aruco API broke between OpenCV 4.6 and 4.7, and the current Ubuntu 22.04 LTS has 4.5 while NixOS has 4.7.
  • Done with help of https://hackage.haskell.org/package/cabal-pkg-config-version-hook, thanks @roberth!
• Test with multiple versions of OpenCV 4.
  • Done, see stack.yaml's nix section.
• Check that enable-nonfree compiles fine.
  • Since I can't test that on Ubuntu easily (see above), probably best to be tested enabled in an OpenCV environment from Nix.
    • Done, I added an entry about this in the CHANGELOG.
• File an issue for Stackage that Stackage 21+ needs repa added back, so that opencv can be added back.
  • This needs this easy issue: Build with vector-0.13 haskell-repa/repa#25
  • And this harder issue regarding GHC 9.4 touch compatibility: Cannot build with GHC 9.4 haskell-repa/repa#26
• File separate issue about QuickCheck flake I observed:
  Repro with stack test opencv --ta --quickcheck-replay=369455:

  getAffineTransform:
    *** Failed! (after 2 tests):
    The points are too far apart; newPoints =
    V3 (V2 0.0 0.0) (V2 0.0 0.0) (V2 0.0 0.0)
    V3 (V2 1.0 1.0) (V2 1.0 1.0) (V2 0.0 (-1.0))
    V3 (V2 0.0 1.0) (V2 0.0 (-1.0)) (V2 (-1.0) 1.0)
    Use --quickcheck-replay=369455 to reproduce.
    Use -p '/getAffineTransform/' to rerun this test only.
  

[ocharles]

Thanks @nh2 ! We have a bunch of commits in our circuithub fork. I'm on holiday for the next two weeks, but I'll try and get on top of things when I'm back and we get this all ship shape again

[nh2]

Another thing that could be done:

The SIFT patent expired in 2020 (https://opencv.org/blog/2020/07/18/opencv-4-4-0/) so we should be able to change our code here to move that out of the enable-nonfree Cabal flag I'm adding in this PR.

[nh2]

@ocharles Do you want to do a short call regarding this?

I'm also in London starting from tonight in case you want to hang out :)

[ocharles]

Hey @nh2, sorry for not getting back earlier! A call sounds good - can you do next week some time? And how long are you in London for?

[nh2]

@ocharles Afternoons from 16:00 work for me (except Monday), I'm in London at least the whole week, probably more.

[htngr]

FYI, this doesn't work with cabal2nix:

> cabal2nix: post-process: cannot replace name binding Bind (Identifier "opencv") (Path [Identifier "pkgs",Identifier "opencv"]) by Bind (Identifier "opencv3") (Path [Identifier "pkgs",Identifier "opencv3"]) because it's not found in set fromList [Bind (Identifier "opencv4") (Path [Identifier "pkgs",Identifier "opencv4"])]
> CallStack (from HasCallStack):
>   error, called at src/Distribution/Nixpkgs/Haskell/FromCabal/PostProcess.hs:211:27 in cabal2nix-2.19.1-24MEcjNppQdH8xbM8xoUph:Distribution.Nixpkgs.Haskell.FromCabal.PostProcess

This is the problem:
https://github.com/NixOS/cabal2nix/blob/2099a1f4594f621bb1a2879b793b860aefe4c027/cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/PostProcess.hs#L359

[nh2]

@htngr That is correct, that hardcode in cabal2nix will need to be fixed once this thing here is merged and released.

If you use this branch, you'll have to patch it, or write a manual cabal2nix output for now, like this:

# TODO: Delete this when https://github.com/LumiGuide/haskell-opencv/pull/157 is in nixpkgs
#       and once cabal2nix has removed its hardcode of `opencv3` in
#       https://github.com/NixOS/cabal2nix/blob/0365d9b77086d26ca5197fb48019cedbb0dce5d2/cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/PostProcess.hs#L359
{ mkDerivation, aeson, base, base64-bytestring, bindings-DSL
, bytestring, Cabal, containers, criterion, data-default, deepseq
, directory, Glob, haskell-src-exts, inline-c, inline-c-cpp
, JuicyPixels, lens, linear, opencv4, primitive, QuickCheck, repa
, tasty, tasty-hunit, tasty-quickcheck, template-haskell, text
, transformers, vector
, async
, haskell-src-meta
, fetchFromGitHub
, lib
}:
mkDerivation {
  pname = "opencv";
  version = "0.0.2.1";
  src = "${fetchFromGitHub {
    owner = "nh2";
    repo = "haskell-opencv";
    rev = "fe0b7c8813aa090835ee974d90c0436d8c95efff";
    sha256 = "0xsjvkpss2iilb8dnp2w229pwgskv5r6yqrbfdhc9avjj6x4qj6i";
  }}/opencv";
  setupHaskellDepends = [ base Cabal ];
  libraryHaskellDepends = [
    aeson base base64-bytestring bindings-DSL bytestring containers
    data-default deepseq inline-c inline-c-cpp JuicyPixels linear
    primitive repa template-haskell text transformers vector
    async
    haskell-src-meta
  ];
  libraryPkgconfigDepends = [ opencv4 ];
  testHaskellDepends = [
    base bytestring containers data-default directory Glob
    haskell-src-exts JuicyPixels lens linear primitive QuickCheck repa
    tasty tasty-hunit tasty-quickcheck template-haskell text
    transformers vector
  ];
  benchmarkHaskellDepends = [ base bytestring criterion repa ];
  hardeningDisable = [ "bindnow" ];
  description = "Haskell binding to OpenCV-3.x";
  license = lib.licenses.bsd3;
  hydraPlatforms = lib.platforms.none;
  # Just because when installing from git, there's no license file.
  preInstall = ''
    touch LICENSE
  '';
}

[ocharles]

Hey @nh2, sorry I never got back to you! Unfortunately time has been very short recently, and as things go that isn't looking to change any time soon 😅 I don't think I have time for a call, but I have viewed all your changes here and they look excellent. I'm very happy for you to just crack on with this and merge/release as necessary. If there's anything in particular you want to talk about, let me know. This looks like a sensible and incremental path forward though, and I can't see anything remotely controversial. Good work!