Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not uploaded a forked library #1183

Closed
arashsoftco opened this issue Mar 15, 2021 · 5 comments · Fixed by #1342
Closed

can not uploaded a forked library #1183

arashsoftco opened this issue Mar 15, 2021 · 5 comments · Fixed by #1342
Assignees
Labels
[type] bug Something isn't working (resulting in patch-version)

Comments

@arashsoftco
Copy link

hi i just want to edit some part of h5p interactive video
i clone this rep:
https://github.com/h5p/h5p-interactive-video
then edit some part just semantics part
and then pack it with h5p cli

arash@arash-bisotuntech:~/Desktop/screenlike$ h5p pack -r h5p-interactive-video-master aPacking 1 library to file...
h5p-interactive-video-master OK 1.22.4

files uploaded here:
https://germancdn.abrito.ir/s/aitNiXDgM9odqbs

and upload to h5p nodejs library
but it stuck at Loading installed libraries from REST endpoint ...

@sr258
Copy link
Member

sr258 commented Mar 15, 2021

This is partly a bug, as the library list should still load even if libraries are missing.

But the main problem is that you need to include all the dependencies of the interactive video in the .h5p package. Check out what a normal h5p file with an interactive video contains. There are dozens of libraries you need to include.

@arashsoftco
Copy link
Author

did you try the link i have sent?
alll i change to the library is

{
  "semantics": [
    {
      "label": "Interactive Video Editor",
      "fields": [
        {
          "label": "Upload/embed video",
          "fields": [
            {
              "label": "اضافه کردن ویدیو",
              "description": "ویدیو خود را در این بخش اپلود کنید شما میتوانید برای عملکرد بهتر فرمت های متفاوت اپلود کنید"
            },
            {
              "label": "Start screen options (unsupported for YouTube videos)",
              "fields": [
                {
                  "label": "The title of this interactive video",
                  "default": "Interactive Video",
                  "description": "Used in summaries, statistics etc."
                },
                {


2 translation

@sr258
Copy link
Member

sr258 commented Mar 15, 2021

Yes, I did.
But if you don't include all the libraries that are needed by the interactive video, it won't work. You need to look into a original .h5p file of an interactive video and also include all the other libraries.

As you only change the localization, it would be better to localize the library with the language files in language/.

@sr258
Copy link
Member

sr258 commented Mar 15, 2021

Alternatively you can also install the regular content type from the hub first and then upload your patched version. Then all the dependencies are already installed. You must increase the patch version of your forked library, however!

@arashsoftco
Copy link
Author

i guess patching is better work thanks i will try out

@sr258 sr258 added the [type] bug Something isn't working (resulting in patch-version) label Mar 15, 2021
@sr258 sr258 closed this as completed Apr 4, 2021
@sr258 sr258 reopened this Apr 4, 2021
@sr258 sr258 self-assigned this Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[type] bug Something isn't working (resulting in patch-version)
Projects
None yet
2 participants