Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dot in path prevent installation of content-type #1339

Closed
DegrangeM opened this issue Apr 24, 2021 · 1 comment · Fixed by #1341
Closed

dot in path prevent installation of content-type #1339

DegrangeM opened this issue Apr 24, 2021 · 1 comment · Fixed by #1341
Assignees
@sr258

Comments

@DegrangeM
Copy link
Contributor 

  h5p:PackageValidator checking core version for Skulpt-1.0 +1ms
  h5p:PackageValidator checking if all js and css file references in the preloaded section of the library metadata are present in package +0ms
  h5p:PackageValidator checking if file Skulpt-1.0/./lib/skulpt.min.js exists +1ms
  h5p:PackageValidator file Skulpt-1.0/./lib/skulpt.min.js does not exist +1ms
@sr258
Copy link
Member

sr258 commented Apr 25, 2021

We'll fix this. It's still a non-standard path. The paths to library files should simply start with the directory.

@sr258 sr258 self-assigned this Apr 25, 2021
sr258 added a commit that referenced this issue Apr 25, 2021
@sr258
fix(h5p-server): package validator accepts dots in library file paths
c1c209e 
Fixes #1339
@sr258 sr258 mentioned this issue Apr 25, 2021
Merged
sr258 added a commit that referenced this issue Apr 25, 2021
@sr258
fix(h5p-server): package validator accepts dots in library file paths (…
e5ac643 
…#1341)

Fixes #1339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sr258 sr258

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sr258 @DegrangeM