Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seekbar, volume): add the ability to control the direction of se… #71

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

jspizziri
Copy link
Contributor

…ek and volume PanResponders

@jspizziri
Copy link
Contributor Author

The purpose of this PR is to allow for the control of the PanReponders in the event a transformation has occurred on the video player view.

As a specific example, we support fullscreen mode via an animated style transformation on a view wrapping the video player. When the device is in a Landscape orientation the player is either under a 90deg or -90deg rotation. As it currently stands the PanResponders don't like this as they currently only support panning along the x axis, however, we now need to pan on the y. Moreover, you need the ability to control the inversion of the responder in these situations as well given the negative or positive direction of rotation.

Would love feedback, and thanks for the lib.

@LunatiqueCoder
Copy link
Owner

Ohh this looks actually very nice! I'll try to have a look this weekend. Thank you for the PR and feedback!

@jspizziri
Copy link
Contributor Author

@LunatiqueCoder any thoughts on this? It's not super pressing for me as I've published my fork to npm, but I would love to not have to use a fork :).

@LunatiqueCoder
Copy link
Owner

Ahh sorry, I was so busy lately. I'll try again this week. 🙈 Sorry for the inconvenience.

The code looks good, I just have to test it. 👌

@jspizziri
Copy link
Contributor Author

no apologies needed!

@jspizziri
Copy link
Contributor Author

Just a friendly ping on this.

@LunatiqueCoder LunatiqueCoder merged commit 009b3d2 into LunatiqueCoder:master Jul 2, 2023
@LunatiqueCoder
Copy link
Owner

Thank you very much! I didn't test it very carefully, but it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants