-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Trial Deck card The Trial of Strategy #595
Comments
Support for Trial Deck now in v0.102.2. Of course Building 81 required and enable Trials in Settings! To see the character's trial, open the character sheet. There is a Trial Icon under the Personal Quest. Some trials are applied automatically. Trial of Strategy should hopefully work as expected. Trials can be marked as completed in Scenario Summary. Happy about feedback and testing! |
I saw this update on Github on Saturday and was very excited and eager to test out support of this new feature. Our group will be playing Friday, and we will be able to give support for the Trial of Strategy a test run.
However, my character is the Frozen Fist and currently has the Trials of Trials, which is an INSANE trial for the Fist since he routinely damages himself most every round to reclaim a card from his discard pile. This trial results in 10+ battle cards drawn for a typical 12-15 round scenario. The release of Secretariat’s support for Trial cards coincided with me running the Fist’s solo adventure on Saturday so I did get to give the support for Trial of Trials a test run, and I was very pleased with how it flawlessly supported drawing a total of 23 battle cards most every round of an epic 27 round scenario! I completed just 10 of the 23 battle cards, so I have not yet satisfied this trial so I’ll be testing it again this Friday, but the support was a big help for my solo adventure.
I do have some feedback from my first experience:
1. I did notice that the trial card number to input on the character did not align with the card numbers on Worldhaven github at https://github.com/any2cards/worldhaven/tree/master/images/trial-cards/frosthaven. I do know that in my 1st printing box there is Frosthaven errata says that the trial deck in the Building 81 envelope should be re-arranged in reverse order, perhaps because the card numbers were printed in reverse order. Re-arranging the deck order per the errata instructions puts the Trial of Weakness (0360) on the top of the deck as 1st card, while the Trial of Strategy (0359) would be the 2nd card of the deck. I noticed that in Secretariat, the corresponding card number for Trial of Strategy is 0349 and the Trial of Trials is 0356, not aligning with the card numbers in Worldhaven’s github. I’m not sure if this is because the Worldhaven card numbers are wrong, or if they were coded in Secretariat in reverse order. For now, I’ve got the correct cards for our characters for our campaign in Secretariat, but it took me some figuring out the order was reversed from the images in Worldhaven.
2. Back to the specific case of the Frozen Fist and the Trial of Trials card. The Frozen Fist core class persistent ability card One with the Mountain (OwtM) states: “At the end of each round, either before or after discarding all active round bonuses, you may recover one card you played this round from your discard pile by suffering 2+(X/2) (rounded down) damage, where X is equal to the card level.” The Trial of Trials card states: “During each scenario, draw one additional battle goal at the end of the round in which you suffered damage…” Technically, I think the order of these respective end of round activities are ambiguous and could be left to the player to determine the order.
* If OwtM is resolved first, then Trial of Trials would almost always result in a battle goal being drawn since the player is doing damage to the Fist almost every round regardless of monster attacks or other damage incurred. This is what makes this Trial insane for the Fist and this is clearly how Secretariat works as I’m just assuming the battle goal draw is keyed off if the character suffered damage at ANY time during the round, regardless of certain specific end of round order of events. And this is how I played my Fist solo adventure Saturday and it resulted in drawing 23 battle goals over a 27 round epic scenario. INSANE!
* However, I do think there is a case for the Trial of Trials to be resolved before OwtM, and if so, the self-inflicted damage for discard reclaim would not trigger a battle goal draw, and that would mean that the Fist would essentially draw battle goal cards for this trial similar to other classes based on damage suffered from enemies, traps, etc. that actually occurred DURING the round and not from a “simultaneous” end-of-round event. I realize this is a corner case in the Trial of Trials battle goal draw based on a single card of a single class, and I’m not really asking for alternative support (because how would Secretariat know that OwtM was in play?), but I am letting you know about this corner case since I’m playing with it now and I’m not sure it’s practically possible to satisfy this trial. For the 23 battle goal draw I just experience, I would have had to complete 12 of the battle goals, and while I satisfied 10 of them (!!), it still was not enough to satisfy the trial and I would prefer to draw fewer battle goals and increase the probability of completing half of them. But you can’t turn off Trial support for a single character – it’s for all characters or no characters.
Otherwise, I’m very pleased so far with the support for Trials and I appreciate the effort you’ve put in.
|
Oh, and one other question about marking the Trial complete in the Scenario Summary… what happens in Secretariat when the trial is marked complete? Does Secretariat auto-draw the next trial in the trial deck for the player and add that to their character sheet? (I’m guessing not since I don’t see support for the trial deck itself.) Or does Secretariat just remove the completed trial from their character sheet and await for the player to input the card number of the new trial card they have drawn external to Secretariat?
|
Sorry, one more comment about the Trial of Trials and the Frozen Fist’s OwtM card. The Scenario Summary does get horizontally very large when the Fist draws 12 to 15 to 20+ battle goals. There is a scroller so it’s usable to navigate to other characters – at least on a laptop – but it’s clunky and I’m not sure how that would fare on a phone device or similar small screen. Just thought I’d pass that feedback along for the UI considerations.
|
Thanks for the detailed review. I will take a deeper look later. Just short answering this:
Totally possible, that I worked with the first print data of worldhaven. Will take a look and compare, then fix cards.
Yes, it auto draws a new trial! (I think at start of next scenario). Didn't see a need to implement the full deck, so it's just a new trial on the Character Sheet (next one from deck). |
Okay, we have a problem here: So by now, I just start with 348 and increment. With second edition, I need to do the opposite (and used opposite label). I will try to add a toggle for 2nd printing and put some math on it to get first printing card ID for it. Still think, it was stupid to change card IDs between editions... |
So now easy answer for Frozen Fist and the Trial of Trials. Actually, start and end of round is not completely defined. So if OwtM and you want not to trigger a new Battle Goal, just click "Next Round", Trial of Trials is not triggered and THEN apply the damage to fist. So you can define that order by yourself. |
How does Secretariat know what is the next card on the top of the deck. I’m dropping into Secretariat’s trial support having my four-player group already drawn the deck down to just the last two cards in the deck. How would Secretariat know the cards we have already drawn and completed?
|
I wasn’t sure but it did seem like the card numbers changed between printings. My hardcopy box set is 1st printing, but I use Vorpal Board to play online with my group and I use all the graphics from Worldhaven which I understood to be 2nd printing.
|
Ahhhh… So if I apply the self-damage to Fist *after* clicking New Round but *before* initiative input and Draw Cards for the new round, it never triggers the Trial of Trials battle goal draw?? Sweet.
|
So changes in v0.102.5:
So I am happy, if you can checkout v0.102.5 and provide feedback, if your issues are solved with this. |
Awesome. I’ll update my server and will check them out during our Friday session
From: Lurkars ***@***.***>
Sent: Tuesday, October 29, 2024 5:04 PM
To: Lurkars/gloomhavensecretariat ***@***.***>
Cc: Timothy Bennett ***@***.***>; Assign ***@***.***>
Subject: Re: [Lurkars/gloomhavensecretariat] Support for Trial Deck card The Trial of Strategy (Issue #595)
So changes in v0.102.5<https://github.com/Lurkars/gloomhavensecretariat/releases/tag/v0.102.5>:
* Go to Campaign Management to toggle to "second edition" for Frosthaven for new Card Id support (708 - cardnumber is translation for 1st vs. 2nd printing, so it just displays other numbers
* Remove draw battle goal, when damage is suffered "between rounds"
* make Battle Goal list scrollable in Scenario Summary
So I am happy, if you can checkout v0.102.5<https://github.com/Lurkars/gloomhavensecretariat/releases/tag/v0.102.5> and provide feedback, if your issues are solved with this.
—
Reply to this email directly, view it on GitHub<#595 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYMVKDLKA2X7N5BP63XZA3Z6AA4TAVCNFSM6AAAAABK3VF75GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBVGQYTEMRSGE>.
You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>
|
I upgraded to v0.102.5 and I see this version in the Server Connection dialog. However, I don’t see the version on the client side in the About dialog (still shows v0.102.4) and I don’t see the items below in the UI in the Campaign Management dialog. When I restart my server, the log shows the v0.102.4 client installed.
From: Lurkars ***@***.***>
Sent: Tuesday, October 29, 2024 5:04 PM
To: Lurkars/gloomhavensecretariat ***@***.***>
Cc: Timothy Bennett ***@***.***>; Assign ***@***.***>
Subject: Re: [Lurkars/gloomhavensecretariat] Support for Trial Deck card The Trial of Strategy (Issue #595)
So changes in v0.102.5<https://github.com/Lurkars/gloomhavensecretariat/releases/tag/v0.102.5>:
* Go to Campaign Management to toggle to "second edition" for Frosthaven for new Card Id support (708 - cardnumber is translation for 1st vs. 2nd printing, so it just displays other numbers
* Remove draw battle goal, when damage is suffered "between rounds"
* make Battle Goal list scrollable in Scenario Summary
So I am happy, if you can checkout v0.102.5<https://github.com/Lurkars/gloomhavensecretariat/releases/tag/v0.102.5> and provide feedback, if your issues are solved with this.
—
Reply to this email directly, view it on GitHub<#595 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYMVKDLKA2X7N5BP63XZA3Z6AA4TAVCNFSM6AAAAABK3VF75GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBVGQYTEMRSGE>.
You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>
|
I think you we're just to quick. Release was still building on my comment. It was released like 10-15 minutes after your comment. So check again now. |
Just to answer this: I just store latest index in party data. So I have the deck here in correct (1st printing!) order: https://github.com/Lurkars/gloomhavensecretariat/blob/main/data/fh/trials.json and here is the index stored:
so when 5 cards are already dealt, index 4 is stored. Next player who finished trial, will get next card (so index 5, meaning 6th card in the deck). Since I know the deck is sorted in order, if you manually set the card on player sheet, I just check for highest index number used on characters and adjust stored deck index to it. So if you already dealt x-many cards physically, just set the correct trail card on each player, index get's updated and next card dealt will be x+1 card. |
Sounds good. I' thinking at least one of our players will complete a trial Friday so we will test it
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Lurkars ***@***.***>
Sent: Wednesday, October 30, 2024 3:36:49 AM
To: Lurkars/gloomhavensecretariat ***@***.***>
Cc: Timothy Bennett ***@***.***>; Assign ***@***.***>
Subject: Re: [Lurkars/gloomhavensecretariat] Support for Trial Deck card The Trial of Strategy (Issue #595)
How does Secretariat know what is the next card on the top of the deck. I’m dropping into Secretariat’s trial support having my four-player group already drawn the deck down to just the last two cards in the deck. How would Secretariat know the cards we have already drawn and completed?
Just to answer this: I just store latest index in party data. So I have the deck here in correct (1st printing!) order:
https://github.com/Lurkars/gloomhavensecretariat/blob/main/data/fh/trials.json
and here is the index stored:
https://github.com/Lurkars/gloomhavensecretariat/blob/9f08862c3a24b4ce47522739fed771900c7af92f/src/app/game/model/Party.ts#L65
so when 5 cards are already dealt, index 4 is stored. Next player who finished trial, will get next card (so index 5, meaning 6th card in the deck).
Since I know the deck is sorted in order, if you manually set the card on player sheet, I just check for highest index number used on characters and adjust stored deck index to it.
—
Reply to this email directly, view it on GitHub<#595 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYMVKFEDRNJERQXIOIB3PTZ6CLCDAVCNFSM6AAAAABK3VF75GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGE4DMNBXGU>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
On Friday night, we played using the updated Trials support in v102.6. For the most part, the support of the Trial of Strategy and Trial of Trials cards functioned well during the scenario and the UI upgrades in the Scenario Summary was good. We both successfully completed the Trial of Strategy and Trial of Trials cards during this scenario. However, we noticed a few things as described below:
1. For the Trial of Trials, the double-check gained from one of the Battle Goals was correctly applied in the character sheet. The Trial was marked as completed in Scenario Summary, and the trial card was removed is the character sheet but a new trial card was *not* automatically drawn and added to the character sheet. The card number was blanked. I had to manually draw another trial external to Secretariat and manually input the new trial card number.
2. For the Trial of Strategy, the player successfully completed all three Battle Goals and marked the applicable number of battle goal checks in Scenario Summary as well as checked that trial had been completed. For this trial, the battle goal checks were *not* applied in the character, and the trial card was not removed from the character (and of course a new trial was not automatically drawn). The player had to manually draw a new trial external to Secretariat and change the trial card number in their character sheet.
The player drew the Trial of Victory as their new trial card. We tested how Secretariat might have implemented support for the Trial of Victory as the player has to choose a double-check Battle Goal for each player in the party and assign it to them. We think we know how this works in Secretariat, but I thought I ask you to confirm how a player sets up Trial of Victory for the whole party prior to drawing the initiatives for the first round?
From: Timothy Bennett ***@***.***>
Sent: Wednesday, October 30, 2024 8:34 AM
To: Lurkars/gloomhavensecretariat ***@***.***>; Lurkars/gloomhavensecretariat ***@***.***>
Cc: Assign ***@***.***>
Subject: Re: [Lurkars/gloomhavensecretariat] Support for Trial Deck card The Trial of Strategy (Issue #595)
Sounds good. I' thinking at least one of our players will complete a trial Friday so we will test it
Sent from my T-Mobile 5G Device
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Lurkars ***@***.******@***.***>>
Sent: Wednesday, October 30, 2024 3:36:49 AM
To: Lurkars/gloomhavensecretariat ***@***.******@***.***>>
Cc: Timothy Bennett ***@***.******@***.***>>; Assign ***@***.******@***.***>>
Subject: Re: [Lurkars/gloomhavensecretariat] Support for Trial Deck card The Trial of Strategy (Issue #595)
How does Secretariat know what is the next card on the top of the deck. I'm dropping into Secretariat's trial support having my four-player group already drawn the deck down to just the last two cards in the deck. How would Secretariat know the cards we have already drawn and completed?
Just to answer this: I just store latest index in party data. So I have the deck here in correct (1st printing!) order:
https://github.com/Lurkars/gloomhavensecretariat/blob/main/data/fh/trials.json
and here is the index stored:
https://github.com/Lurkars/gloomhavensecretariat/blob/9f08862c3a24b4ce47522739fed771900c7af92f/src/app/game/model/Party.ts#L65
so when 5 cards are already dealt, index 4 is stored. Next player who finished trial, will get next card (so index 5, meaning 6th card in the deck).
Since I know the deck is sorted in order, if you manually set the card on player sheet, I just check for highest index number used on characters and adjust stored deck index to it.
-
Reply to this email directly, view it on GitHub<#595 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABYMVKFEDRNJERQXIOIB3PTZ6CLCDAVCNFSM6AAAAABK3VF75GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGE4DMNBXGU>.
You are receiving this because you were assigned.Message ID: ***@***.******@***.***>>
|
Cannot reproduce why battle goals/trial completion did not work for one character. Maybe send an Email with a data dump, if this appears in future. Drawing new trials worked after starting new scenario, I fixed this now in v0.102.7. So new trial card should be drawn after scenario finish. I also added support for Trial of Victory just by making the Battle Goal drawing to just show one 2-check card. You can then click "redraw" or "draw another card to change this card. |
Is your feature request related to a problem? Please describe.
The Trial of Strategy card requires the player to draw and keep all three battle cards every scenario until the trial is completed. The trial is complete when the player successfully completes all three battle goals during scenario play. The battle goal interface currently does not support keeping more than one battle goal, nor does the scenario complete screen allow a player to tally checks for more than one battle goal completed.
Describe the solution you'd like
Ideally, support for the trial cards, but aside from formal support for the trial cards at least have a way to at least support the Trial of Strategy.
Describe alternatives you've considered
Perhaps in the battle goal selection interface, a way to toggle the Trial of Strategy and the interface allow selection of all three battle goals. There would need to maintain redraw capabilities as current, since the trial card allows for redrawing in the event two battle goals drawn are mutually exclusive. The scenario complete interface would need to know that player had multiple battle goals selected
Additional context
No response
The text was updated successfully, but these errors were encountered: