Allow to communicate ErrorMsg for CHECKURL-FAILURE via RemoteError exception #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ception Similar pattern already used in various other locations but not for this check. I used .rstrip() to guarantee no dangling whitespaces (which would break the existing test). https://git-annex.branchable.com/design/external_special_remote_protocol/ says that CHECKURL-FAILURE ErrorMsg Indicates that the requested url could not be accessed. so ErrorMsg is entirely legit.
yarikoptic
added a commit
to yarikoptic/datalad
that referenced
this pull request
Aug 29, 2024
… remotes Inspired by - datalad/datalad-container#267 but to be of benefit, requires review/merge/release of - Lykos153/AnnexRemote#106 But should be safe otherwise since ATM (without the above PR) AnnexRemote simply ignores the message
This was referenced Aug 29, 2024
|
The change is small, test was added. So if no objections, I will merge in few days |
|
Let's merge and release |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar pattern already used in various other locations but not for this check. I used .rstrip() to guarantee no dangling whitespaces (which would break the existing test).
https://git-annex.branchable.com/design/external_special_remote_protocol/ says that
so ErrorMsg is entirely legit.