-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle cjk medicalwei #7
Conversation
Oh! I was about to respond to your other comment, I actually know @medicalwei so I would have been fine just asking them to rebase. Also, I want to try taking a look at this to see if we can mitigate some of the performance hits that they mentioned in the original PR |
Almost forgot to ask as well, did you confirm whether this fixes #5? |
Nope! And if you know him that would be better anyway, I just had already done the rebase so figured it would be convenient. I'll close this. |
#5 can be fixed by these commits, and the pull request looks good to me. Can you reopen the PR? |
Hey guys! Just tested here and I confirm that this indeed fixes #5 :) |
JFYI I'm still considering this, but I've also been investigating seeing if (thanks to some input from Yao Wei and some other friends!) we can get pango to simply render things as monospace - which actually should have an effect on CJK character spacing https://docs.gtk.org/Pango/vfunc.FontFamily.is_monospace.html and might actually be the correct fix here |
You might need to also investigate whether this will break ligatures that the fonts might have. The method I proposed breaks these if any of the codepoints that forms a ligature is not in ASCII, which Some fonts like Indic or Sanskrit ones may use. |
Basically Yao Wei's idea from #7, but use start using grapheme clusters instead of character indices in order to avoid breaking languages such as Hindi. Co-authored-by: Yao Wei (魏銘廷) <mwei@debian.org>
No description provided.