chore: use more specific adb GOTOs for XiaoMi #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did some comparisons and removed some repeats 9039, 904e. Changed from blanket accept all to default drop unknowns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looked at cleaning up a little more with intention of adding another vendor from default blanket accept, to default drop unknown values.
Did some comparisons and removed these vague
SYMLINK+="android_adb"for 9039, 904e.9039 appears to be adb
0368 was also another vague
SYMLINK+="android_adb"link, but appears to be adbmentioned as mtp,adb here and here.
Several modes also described here for 1240,1248,1210,1218,1220,1228.