Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Fix Android 5.x Boot Loop issues #2193

Closed
wants to merge 1 commit into from
Closed

Fix Android 5.x Boot Loop issues #2193

wants to merge 1 commit into from

Conversation

dbergloev
Copy link
Contributor

Whether or not this is an Xposed issue I am not sure. But trying to add a hook to ActivityThread after it has been loaded will cause a boot loop issue. It seams that doing so destroys the entire dalvik cache for some reason. Moving the hook to ZygoteInit, like in pre-lollipop, fixes the boot loop issue.

@M66B M66B closed this in a80c0dd May 21, 2015
@M66B
Copy link
Owner

M66B commented May 21, 2015

Thanks for figuring this out!
I have been searching for this for ages, but somehow I missed it.
I didn't merge your pull request, because XPrivacy needs to support pre-lollipop devices too.

@dbergloev
Copy link
Contributor Author

I made it so that it would work like always on pre-lollipop. In pre-lollipop you execute hookAll(null) from zygote. I moved that one hook to a new hook() method, this is executed from zygote on all versions, which means that on pre-lollipop it will work as it has always done since both hookAll(null) and hookAll() is executed right after one another.

@M66B
Copy link
Owner

M66B commented May 21, 2015

True, but I have made this more explicit.

@M66B
Copy link
Owner

M66B commented May 21, 2015

What is your XDA user name (for credits) ?

@dbergloev
Copy link
Contributor Author

It's the same as here, only with an underscore at the beginning (Github does not support that), so "dk_zero-cool".

@M66B
Copy link
Owner

M66B commented May 21, 2015

@M66B
Copy link
Owner

M66B commented May 21, 2015

A test version is available here: #2162

@dbergloev
Copy link
Contributor Author

Thanks, but I don't really use this at the moment, I don't need it as I am very strickt about what I install on my devices. I just followed the thread and got tired of the people that does not know how much time these things can take from the people working on it, and you seamed like you did not have that time currently. Since I like a challenge and had the time to spend, I thought that I would lend a hand.

@M66B
Copy link
Owner

M66B commented May 21, 2015

I am really glad you found this problem and probably a lot of other people too!

@M66B
Copy link
Owner

M66B commented May 21, 2015

And, yes, things like this are quite time consuming. Even testing your fix did cost time and waiting for a complete OAT each time a boot fails is no fun at all too.

@dbergloev
Copy link
Contributor Author

Yes it requires a lot of rebooting, recovery shell to disable the module each time and so on. Just a quick note, if you have anything in your module that adds hooks to native methods, those features will not currently work on Lollipop. The Lollipop versions of Xposed does not allow hooks on native methods, not sure why, but Rovo has disabled it until he has time to test it properly. Just a good idea to mention this on the thread if you have such features.

@M66B
Copy link
Owner

M66B commented May 21, 2015

I was aware of the limitation of hooking native methods, but some of the super alpha versions do support hooking of native methods (and it actually works). I will add a note about this, because I can imagine not everybody knows/remembers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants