Added pre-commit hooks #118

AvdhutPailwan · 2024-05-14T10:17:30Z

pre-commit hooks added using husky and lint-staged is used which will run on every commit

Description

pre-commit hooks are added using husky
lint-staged is used to lint staged files and with pre-commit hook lint-staged can lint all files before every commit
pre-commit hooks will stop a user from committing a bad piece of code
This closes the ticket Adding pre-commit hooks #93
This closes the ticket Following the issue #93 adding prettier to the project #120

Motivation and Context

It can solve the problem of inconsistent code styling across all development platforms and the pre-commit can also be used to check if all test pass before every run

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit

vercel · 2024-05-14T10:17:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nestondc	❌ Failed (Inspect)			May 15, 2024 4:39pm

github-actions

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged

…pdate in README.md

MAVRICK-1 · 2024-05-15T03:30:34Z

@ratnesh-maurya please review this PR

MAVRICK-1 · 2024-05-15T15:44:27Z

@AvdhutPailwan their is merge conflict plz solve it , then it is ready to merge

AvdhutPailwan · 2024-05-15T16:05:45Z

@MAVRICK-1 I have resolved the merge conflict please check it.

deployment was failing because it couldn't find ResetPassword

This reverts commit 558218c.

This reverts commit 5775c97.

This reverts commit b9c90f6.

This reverts commit aaa78c0.

This reverts commit 82d8bfb.

AvdhutPailwan · 2024-05-15T16:39:32Z

I have resolved merge conflict please merge it

AvdhutPailwan · 2024-05-15T16:39:51Z

I have resolved merge conflict please merge it

@MAVRICK-1 deployment may fail due to a not found file but you can merge this successfully

MAVRICK-1 · 2024-05-15T16:41:30Z

@AvdhutPailwan why so much commits? you can do it easy way by accepting both the changes.

MAVRICK-1 · 2024-05-15T17:05:13Z

@AvdhutPailwan Don't forget to give us a ⭐

AvdhutPailwan · 2024-05-15T17:10:54Z

@AvdhutPailwan Don't forget to give us a ⭐

Yup 👍🏻

AvdhutPailwan · 2024-05-15T17:18:01Z

@AvdhutPailwan why so much commits? you can do it easy way by accepting both the changes.

Actually I made changes but as new commits were getting merged new conflicts were arising that's why I made changes then reverted and deployment were failing as well so that's why so many commits happened 😅

* rectified all the css error except about page (#114) * proceed fixed (#115) * rectified all the css error except about page (#116) * Update greetings.yaml * Create Contributing.md (#122) * Rename create contributing.md to contributing.md * Forgot password (#134) * added forget password feature * reverted changes made to the package.json * made a change in the reset password folder * Main page groceries, electronics, fashion buttons Not Working Fixed (#137) * New branch * Issue fixed * Fix issue 72 (#143) * rectified all the css error except about page * Updated Footer --------- Co-authored-by: MAVRICK <mavrickrishi@gmail.com> * Added pre-commit hooks (#118) * Added pre-commit hooks Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit * Added prettier Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged * Try formatting with prettier and pre-commit hook * Try formatting with prettier and pre-commit hook 2 * Docs: after adding pre-commit hooks did the necessary documentation update in README.md * Update App.js to resolve merge conflict * Update App.js to resolve deployment failure deployment was failing because it couldn't find ResetPassword * Revert "Added prettier" This reverts commit 558218c. * Reapply "Added prettier" This reverts commit 5775c97. * Revert "Update App.js to resolve deployment failure" This reverts commit b9c90f6. * Revert "Update App.js to resolve merge conflict" This reverts commit aaa78c0. * Update nav.js to resolve merge conflict in nav.js * Revert "Update nav.js to resolve merge conflict in nav.js" This reverts commit 82d8bfb. * Update App.js to resolve merge conflict in App.js * Update footer.js to resolve merge conflict in footer.js * Update nav.js to resolve merge conflict in nav.js --------- Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com>

* My_Account_form_feature_added * refac:storing data in firebase storage of user * for edit feature added * refac:some UI of MY_Account feature * refac:some bug fix about conflict * refac:bug fix of deployment issue * Merge Dev to main (#146) * rectified all the css error except about page (#114) * proceed fixed (#115) * rectified all the css error except about page (#116) * Update greetings.yaml * Create Contributing.md (#122) * Rename create contributing.md to contributing.md * Forgot password (#134) * added forget password feature * reverted changes made to the package.json * made a change in the reset password folder * Main page groceries, electronics, fashion buttons Not Working Fixed (#137) * New branch * Issue fixed * Fix issue 72 (#143) * rectified all the css error except about page * Updated Footer --------- Co-authored-by: MAVRICK <mavrickrishi@gmail.com> * Added pre-commit hooks (#118) * Added pre-commit hooks Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit * Added prettier Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged * Try formatting with prettier and pre-commit hook * Try formatting with prettier and pre-commit hook 2 * Docs: after adding pre-commit hooks did the necessary documentation update in README.md * Update App.js to resolve merge conflict * Update App.js to resolve deployment failure deployment was failing because it couldn't find ResetPassword * Revert "Added prettier" This reverts commit 558218c. * Reapply "Added prettier" This reverts commit 5775c97. * Revert "Update App.js to resolve deployment failure" This reverts commit b9c90f6. * Revert "Update App.js to resolve merge conflict" This reverts commit aaa78c0. * Update nav.js to resolve merge conflict in nav.js * Revert "Update nav.js to resolve merge conflict in nav.js" This reverts commit 82d8bfb. * Update App.js to resolve merge conflict in App.js * Update footer.js to resolve merge conflict in footer.js * Update nav.js to resolve merge conflict in nav.js --------- Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com> * refac:feature_fix/user primary key to uid,default photo, name, email in user firebase , if the user logged in from Google * refac:conflict resolved --------- Co-authored-by: anwesha <ANWESHA@DESKTOP-ALJFO4P.com> Co-authored-by: Rishi Mondal <146999057+MAVRICK-1@users.noreply.github.com> Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com>

* rectified all the css error except about page (#114) * proceed fixed (#115) * rectified all the css error except about page (#116) * Update greetings.yaml * Create Contributing.md (#122) * Rename create contributing.md to contributing.md * Forgot password (#134) * added forget password feature * reverted changes made to the package.json * made a change in the reset password folder * Main page groceries, electronics, fashion buttons Not Working Fixed (#137) * New branch * Issue fixed * Fix issue 72 (#143) * rectified all the css error except about page * Updated Footer --------- Co-authored-by: MAVRICK <mavrickrishi@gmail.com> * Added pre-commit hooks (#118) * Added pre-commit hooks Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit * Added prettier Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged * Try formatting with prettier and pre-commit hook * Try formatting with prettier and pre-commit hook 2 * Docs: after adding pre-commit hooks did the necessary documentation update in README.md * Update App.js to resolve merge conflict * Update App.js to resolve deployment failure deployment was failing because it couldn't find ResetPassword * Revert "Added prettier" This reverts commit 558218c. * Reapply "Added prettier" This reverts commit 5775c97. * Revert "Update App.js to resolve deployment failure" This reverts commit b9c90f6. * Revert "Update App.js to resolve merge conflict" This reverts commit aaa78c0. * Update nav.js to resolve merge conflict in nav.js * Revert "Update nav.js to resolve merge conflict in nav.js" This reverts commit 82d8bfb. * Update App.js to resolve merge conflict in App.js * Update footer.js to resolve merge conflict in footer.js * Update nav.js to resolve merge conflict in nav.js * Feat/my account (#128) * My_Account_form_feature_added * refac:storing data in firebase storage of user * for edit feature added * refac:some UI of MY_Account feature * refac:some bug fix about conflict * refac:bug fix of deployment issue * Merge Dev to main (#146) * rectified all the css error except about page (#114) * proceed fixed (#115) * rectified all the css error except about page (#116) * Update greetings.yaml * Create Contributing.md (#122) * Rename create contributing.md to contributing.md * Forgot password (#134) * added forget password feature * reverted changes made to the package.json * made a change in the reset password folder * Main page groceries, electronics, fashion buttons Not Working Fixed (#137) * New branch * Issue fixed * Fix issue 72 (#143) * rectified all the css error except about page * Updated Footer --------- Co-authored-by: MAVRICK <mavrickrishi@gmail.com> * Added pre-commit hooks (#118) * Added pre-commit hooks Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit * Added prettier Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged * Try formatting with prettier and pre-commit hook * Try formatting with prettier and pre-commit hook 2 * Docs: after adding pre-commit hooks did the necessary documentation update in README.md * Update App.js to resolve merge conflict * Update App.js to resolve deployment failure deployment was failing because it couldn't find ResetPassword * Revert "Added prettier" This reverts commit 558218c. * Reapply "Added prettier" This reverts commit 5775c97. * Revert "Update App.js to resolve deployment failure" This reverts commit b9c90f6. * Revert "Update App.js to resolve merge conflict" This reverts commit aaa78c0. * Update nav.js to resolve merge conflict in nav.js * Revert "Update nav.js to resolve merge conflict in nav.js" This reverts commit 82d8bfb. * Update App.js to resolve merge conflict in App.js * Update footer.js to resolve merge conflict in footer.js * Update nav.js to resolve merge conflict in nav.js --------- Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com> * refac:feature_fix/user primary key to uid,default photo, name, email in user firebase , if the user logged in from Google * refac:conflict resolved --------- Co-authored-by: anwesha <ANWESHA@DESKTOP-ALJFO4P.com> Co-authored-by: Rishi Mondal <146999057+MAVRICK-1@users.noreply.github.com> Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com> * feat:GoToTop button added (#148) * Issue/149: Image Optimization for reducing loading time (#153) * optimized images to reduce the loading time * optimized images to reduce the loading time * Compare page and it's functionality Fixed (#160) * New branch * compare * Re design card (#173) * add search route for display search products * search the products * dependencies * add yarn.lock in gitignore * redesign the card sucessfully --------- Co-authored-by: Varsani2520 <varsaniranjani2520@gmail.com> * updated about (#177) * updated about * updated about * Shop dropdown text (#176) * add the hyperlink in my wishlist (#174) Co-authored-by: Rishi Mondal <146999057+MAVRICK-1@users.noreply.github.com> * Update greetings.yaml * Location. (no need for country names, Indian cities name should be there) Fixed (#179) * New branch * cities added * Chatbot added (#180) --------- Co-authored-by: Hemanth kumar <rajva5727@gmail.com> Co-authored-by: deekshithapalla <159523774+deekshithapalla@users.noreply.github.com> Co-authored-by: Niharika Goulikar <124892559+Niharika0104@users.noreply.github.com> Co-authored-by: Adarsh <120160355+jinx-vi-0@users.noreply.github.com> Co-authored-by: Avdhut Pailwan <74597375+AvdhutPailwan@users.noreply.github.com> Co-authored-by: Anwesha Das <116761608+anwesha2002@users.noreply.github.com> Co-authored-by: anwesha <ANWESHA@DESKTOP-ALJFO4P.com> Co-authored-by: Arghyadeep09 <90449806+Arghyadeep09@users.noreply.github.com> Co-authored-by: Siddhi T <82750191+SiddhiT28@users.noreply.github.com> Co-authored-by: v_a_r_s_a_n_i <137641079+Varsani2520@users.noreply.github.com> Co-authored-by: Varsani2520 <varsaniranjani2520@gmail.com> Co-authored-by: Rajveer <142779809+root-0101@users.noreply.github.com> Co-authored-by: Vedant Anand <136731196+VedantAnand17@users.noreply.github.com> Co-authored-by: aashkaaaaaa <138461600+aashkaaaaaa@users.noreply.github.com> Co-authored-by: sau-mili <146661411+sau-mili@users.noreply.github.com>

Added pre-commit hooks

5914c8f

Description: pre-commit hooks added using husky and lint-staged is used which will run on every commit

github-actions bot reviewed May 14, 2024

View reviewed changes

vercel bot deployed to Preview May 14, 2024 10:19 View deployment

MAVRICK-1 mentioned this pull request May 14, 2024

Following the issue #93 adding prettier to the project #120

Closed

Added prettier

558218c

Prettier configurations are added and prettier configured to work with pre-commit hooks and lint-staged

vercel bot deployed to Preview May 14, 2024 16:08 View deployment

AvdhutPailwan added 2 commits May 14, 2024 21:38

Try formatting with prettier and pre-commit hook

d2e1332

Try formatting with prettier and pre-commit hook 2

bc31433

vercel bot deployed to Preview May 14, 2024 16:12 View deployment

Docs: after adding pre-commit hooks did the necessary documentation u…

eafe69e

…pdate in README.md

vercel bot deployed to Preview May 14, 2024 16:18 View deployment

MAVRICK-1 assigned ratnesh-maurya May 15, 2024

MAVRICK-1 assigned AvdhutPailwan and unassigned ratnesh-maurya May 15, 2024

MAVRICK-1 requested a review from ratnesh-maurya May 15, 2024 03:32

MAVRICK-1 added GSSoC'24 Under GirlScript Summer of code level3 hard gssoc Under GirlScript Summer of code labels May 15, 2024

Update App.js to resolve merge conflict

aaa78c0

vercel bot had a problem deploying to Preview May 15, 2024 16:06 Failure

Update App.js to resolve deployment failure

b9c90f6

deployment was failing because it couldn't find ResetPassword

vercel bot deployed to Preview May 15, 2024 16:16 View deployment

Revert "Added prettier"

5775c97

This reverts commit 558218c.

vercel bot deployed to Preview May 15, 2024 16:20 View deployment

AvdhutPailwan added 2 commits May 15, 2024 21:53

Reapply "Added prettier"

f846eca

This reverts commit 5775c97.

Revert "Update App.js to resolve deployment failure"

7c0f57f

This reverts commit b9c90f6.

Revert "Update App.js to resolve merge conflict"

ee22779

This reverts commit aaa78c0.

vercel bot deployed to Preview May 15, 2024 16:25 View deployment

vercel bot deployed to Preview May 15, 2024 16:27 View deployment

AvdhutPailwan and others added 3 commits May 15, 2024 22:00

Update nav.js to resolve merge conflict in nav.js

82d8bfb

Revert "Update nav.js to resolve merge conflict in nav.js"

3f210b7

This reverts commit 82d8bfb.

Update App.js to resolve merge conflict in App.js

909a7ac

vercel bot had a problem deploying to Preview May 15, 2024 16:36 Failure

AvdhutPailwan added 2 commits May 15, 2024 22:07

Update footer.js to resolve merge conflict in footer.js

8ef2222

Update nav.js to resolve merge conflict in nav.js

58952e3

vercel bot had a problem deploying to Preview May 15, 2024 16:39 Failure

MAVRICK-1 merged commit a9a3023 into MAVRICK-1:dev May 15, 2024
1 of 2 checks passed

MAVRICK-1 mentioned this pull request May 19, 2024

merging updates to main (#175) #182

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added pre-commit hooks #118

Added pre-commit hooks #118

AvdhutPailwan commented May 14, 2024 •

edited

Loading

vercel bot commented May 14, 2024 •

edited

Loading

github-actions bot left a comment

MAVRICK-1 commented May 15, 2024 •

edited

Loading

MAVRICK-1 commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024 •

edited

Loading

MAVRICK-1 commented May 15, 2024

MAVRICK-1 commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024

Added pre-commit hooks #118

Added pre-commit hooks #118

Conversation

AvdhutPailwan commented May 14, 2024 • edited Loading

Description

Motivation and Context

Types of changes

Checklist:

vercel bot commented May 14, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

MAVRICK-1 commented May 15, 2024 • edited Loading

MAVRICK-1 commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024 • edited Loading

MAVRICK-1 commented May 15, 2024

MAVRICK-1 commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 15, 2024

AvdhutPailwan commented May 14, 2024 •

edited

Loading

vercel bot commented May 14, 2024 •

edited

Loading

MAVRICK-1 commented May 15, 2024 •

edited

Loading

AvdhutPailwan commented May 15, 2024 •

edited

Loading