Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to zip 2.0 #32

Merged
merged 2 commits into from
Aug 24, 2024
Merged

Update to zip 2.0 #32

merged 2 commits into from
Aug 24, 2024

Conversation

DaniPopes
Copy link
Contributor

Plus some cargo/clippy warning fixes.

Closes #31
Fixes #14

MCOfficer
MCOfficer requested changes Aug 24, 2024
View reviewed changes
Copy link
Owner

@MCOfficer MCOfficer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, this all seems reasonable. I'd love for the tests to use diff_dir, but as long as it's flaky i guess this is the better solution.

Cargo.toml Outdated Show resolved Hide resolved
@DaniPopes @MCOfficer
Update Cargo.toml
57ab321 
Co-authored-by: M*C*O <mcofficer@gmx.de>
@MCOfficer MCOfficer merged commit 379f6ed into MCOfficer:master Aug 24, 2024
1 check passed
@DaniPopes DaniPopes deleted the zip2 branch August 24, 2024 10:36
@DaniPopes
Copy link
Contributor Author

FYI dir_diff wasn't removed, just the use statement which was unused.

@MCOfficer
Copy link
Owner

Oh, i misread that in conjunction with the collapsed assert!. thanks!

@DaniPopes DaniPopes mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCOfficer MCOfficer MCOfficer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The file name is incorrectly encoded after the file is decompressed
2 participants
@DaniPopes @MCOfficer