Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HVUPDI_SUPPORT list for programmers. #2

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

janegilruud
Copy link

Tried to implement a way to list which UPDI HV variants the different programmers support.

@MCUdude
Copy link
Owner

MCUdude commented Jul 6, 2022

Thanks for the PR!

It seems like there's an issue with the parser though. I'm getting the following error:

$ ./avrdude -cpickit4_updi -pattiny1616 
avrdude: error at /Users/hans/Downloads/avrdude/src/avrdude.conf:399: syntax error
avrdude: error reading system wide configuration file "/Users/hans/Downloads/avrdude/src/avrdude.conf"

(avrdude.conf line 399)

  usbproduct = "";

BTW, for backward compatibility with older avrdude.conf files, is hvupdi_support optional?

@janegilruud
Copy link
Author

Darn. I'm in no way an expert on this.

My intention was to make it optional. Avrdude should work fine with an avrdude.conf without hvupdi_support, except for HV UPDI. The need for an avrdude.conf with hvupdi_support to do HV UPDI I'd call a safety feature. Intentions and actual result might differ at the moment.

@MCUdude
Copy link
Owner

MCUdude commented Jul 7, 2022

The problem now is that I can't get Avrdude to accept the avrdude.conf file regardless if hvupdi_support is present or not...

But thanks for spending your time on this. I appreciate it!

@janegilruud
Copy link
Author

First, I have put hvupdi_support in the prog_parm_usb section, which it why it fails on line 399 which is a usb parameter. Secondly I probably haven't managed to make it optional yet...

@janegilruud
Copy link
Author

Working better now. Hadn't initialized the list.

src/jtag3.c Show resolved Hide resolved
@MCUdude
Copy link
Owner

MCUdude commented Jul 7, 2022

Thanks for going through the code once again and resolving the issue, It seems to work fine now. Tested with a PK4, SNAP, and Xplained Nano UPDI.

@MCUdude MCUdude merged commit 913509d into MCUdude:hv-updi Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants