Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment for OIDC #45

Merged
merged 5 commits into from
Oct 31, 2023
Merged

Update deployment for OIDC #45

merged 5 commits into from
Oct 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 29, 2023

Towards: MDAnalysis/mdanalysis#4326

PR Checklist

  • CHANGELOG updated?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

Trusted publishers have been set.

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #45 (7faeea7) into main (83e7bc9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

🤦🏽 why is py3.12 being called here - is compatible python not work?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

There we go, that's CI fixed - I'm not sure how I feel about this properly, but maybe this is the best approach.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating to trusted publishers and the 3.12 hack.

@@ -35,6 +36,8 @@ jobs:

- id: get-compatible-python
uses: MDAnalysis/mdanalysis-compatible-python@main
with:
release: "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the current py 3.12 hack... MDAnalysis/cookiecutter-mdakit#93

@orbeckst orbeckst merged commit 7edf3e0 into main Oct 31, 2023
23 checks passed
@orbeckst orbeckst deleted the deploy-oidc branch October 31, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants