Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to artifact upload/download to v3 for 2.8.0 release #4784

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 11, 2024

Related to #4783

Artifacts are no longer mutable in v4, which means that the workflow will need to changes to allow for multiple artifacts to be uploaded at the same time.

To avoid spending a lot of time fixing multiple things at the same time (and blocking through review), we rever to the v3 version. After the v2.8.0 release of MDAnalysis, work will be done to update the deploy workflow to v4.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4784.org.readthedocs.build/en/4784/

@IAlibay
Copy link
Member Author

IAlibay commented Nov 11, 2024

This does not trigger any relevant CI workflows, so merging as-is.

@IAlibay IAlibay merged commit b254921 into develop Nov 11, 2024
16 of 24 checks passed
@IAlibay IAlibay deleted the fix-artifact-upload branch November 11, 2024 19:18
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.64%. Comparing base (5eeedd6) to head (ba7ba01).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4784      +/-   ##
===========================================
- Coverage    93.66%   93.64%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21742    22808    +1066     
  Branches      3055     3055              
===========================================
+ Hits         20365    21358     +993     
- Misses         930     1003      +73     
  Partials       447      447              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant