Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deploy.yaml for OIDC #17

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Update deploy.yaml for OIDC #17

merged 4 commits into from
Nov 3, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 29, 2023

No description provided.

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

Trusted publishing is now set up.

@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #17 (bd624c9) into main (db4835c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@IAlibay
Copy link
Member Author

IAlibay commented Oct 31, 2023

Also includes short term fix from: MDAnalysis/cookiecutter-mdakit#93

@IAlibay IAlibay mentioned this pull request Nov 3, 2023
Closed
@IAlibay IAlibay requested a review from orbeckst November 3, 2023 19:22
@IAlibay
Copy link
Member Author

IAlibay commented Nov 3, 2023

Sorry to ping you again for review @orbeckst but at this point you've reviewed nearly all of them 🙃

@orbeckst
Copy link
Member

orbeckst commented Nov 3, 2023

That's ok, at least I have some idea what to expect.

orbeckst
orbeckst approved these changes Nov 3, 2023
View reviewed changes
.github/workflows/deploy.yaml Show resolved Hide resolved
@IAlibay IAlibay merged commit 83bebc9 into main Nov 3, 2023
23 checks passed
@IAlibay IAlibay deleted the deploy-oidc branch November 3, 2023 20:23
@IAlibay IAlibay mentioned this pull request Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IAlibay @orbeckst