Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Language clarifications from emdupre's review

Co-authored-by: Elizabeth DuPre <emd222@cornell.edu>
  • Loading branch information
handwerkerd and emdupre authored Dec 7, 2020
1 parent 28865e6 commit db1aab6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions docs/contributing.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ are ready for further analyses.
Acquisition
-----------

While the development of multi-echo sequences is far beyond the current scope
While the development of multi-echo sequences is beyond the current scope
of tedana, the tedana community is committed to providing guidelines on current
multi-echo implementations. This will include both specific instructions for
how to collect multi-echo data for multiple vendors as well as details about
Expand Down Expand Up @@ -77,7 +77,7 @@ processing, such as motion, cardiac, respiration).
tedana is primarily intended to work on volume data, that is, data that is
still in structured voxel space. This is because several of the currently used denoising metrics rely on spatial continuity, and they have not yet been updated to consider continuity over cortical vertices.
Therefore, surface-based denoising is not currently
within the scope of tedana, but code should be written so that it is a
within the scope of tedana, but code could be written so that it is a
possible option in the future.

Currently tedana works on a single subject, run by run basis; however, methods
Expand All @@ -89,7 +89,7 @@ Visualization
-------------

As part of the processing stream, tedana provides figures and an
HTML-based GUI for inspecting results. These are intended to help
HTML-based report for inspecting results. These are intended to help
users understand the outputs from tedana and diagnose problems. Though a
comprehensive viewer (such as fsleyes) is outside of the scope of tedana, we
will continue to improve the reports and add new information as needed.
Expand Down
6 changes: 3 additions & 3 deletions docs/governance.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Governance
==========
Governance is a hugely important part of any project.
It is especially important to have clear process and communication channels
It is especially important to have clear processes and communication channels
for open source projects that rely on a distributed network of volunteers,
such as ``tedana``.

Expand All @@ -18,7 +18,7 @@ physics, and advanced data processing methods to assume a primary project
leader role.
Even if such a person was interested, it may not benefit the
project to overly rely on the existence of one person.
We developed the
Instead, we developed the
following system with several goals in mind:

- Grow the community.
Expand Down Expand Up @@ -234,7 +234,7 @@ and heavily depend on the

(1) The author closing the PR without merging
(2) The reviewer accepting requested changes or
(3) The dismissing their review, so that the PR can be approved and
(3) The reviewer dismissing their review, so that the PR can be approved and
merged, then the disagreement will be resolved with a vote.
9. Rules governing voting:

Expand Down

0 comments on commit db1aab6

Please sign in to comment.