Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default maPCA option to AIC #843

Closed
eurunuela opened this issue Feb 18, 2022 · 0 comments · Fixed by #849
Closed

Change default maPCA option to AIC #843

eurunuela opened this issue Feb 18, 2022 · 0 comments · Fixed by #849
Labels
effort: low Theoretically less than a day's work good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. impact: medium Improves code/documentation functionality for some users priority: medium Should get addressed soon

Comments

@eurunuela
Copy link
Collaborator

Summary

After discussion at our last meeting, and considering the number of questions re maPCA on Neurostars, we should probably change the default maPCA criterion to AIC (the most conservative). This way, users will get more components in what should give a more similar solution to the kundu_stabilize option.

Next Steps

  • Change maPCA criterion to AIC.
  • Update test results.
@eurunuela eurunuela added good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. priority: medium Should get addressed soon effort: low Theoretically less than a day's work impact: medium Improves code/documentation functionality for some users labels Feb 18, 2022
@eurunuela eurunuela mentioned this issue Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Theoretically less than a day's work good first issue issues that we think are good for new contributors. Equivalent to "very low" effort. impact: medium Improves code/documentation functionality for some users priority: medium Should get addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made AIC the default maPCA option eurunuela/tedana
1 participant
@eurunuela