-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made AIC the default maPCA option #849
Conversation
I think this PR will fix the failing three-echo test in #839. |
Codecov Report
@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 93.27% 93.09% -0.19%
==========================================
Files 27 27
Lines 2217 2217
==========================================
- Hits 2068 2064 -4
- Misses 149 153 +4
Continue to review full report at Codecov.
|
Thanks for this. One thing I would like to see added to our documentation is a very short explanation of why we use AIC by default. Something like...
I doesn't have to be that, but something to that effect would be nice. I also think this probably deserves a |
Let me know what you think of the changes added in c610667.
Done! |
I'll try to look at this more carefully soon, but one thing I've noticed while running tedana is that there's no logging for various pca options. When the default option is used, I'm not sure anywhere in the log will say what the default option is. I think we should add some logging to places like this |
The logging happens here. The only thing that could be missing in my opinion is the maPCA criteria. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded one comment a bit.
I can't figure out how to suggest a change in an area where you didn't make any edits, but I'd replace
https://github.com/eurunuela/tedana/blob/c61066788779da683d6246dc905b326a74d0bd93/tedana/decomposition/pca.py#L228
with
LGR.info(f"Computing PCA of optimally combined multi-echo data with selection criteria: {algorithm}")
That will have slightly ugly parsing if someone enters a number for algorithm
, but, if someone is entering a number, they'll hopefully understand what they're doing.
Otherwise, this all looks good to me.
Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
Thank you for your feedback @handwerkerd, b28a282 should address your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @eurunuela !
Closes #843 .
Changes proposed in this pull request:
mdl
toaic
.aic
the default maPCA option.aic
.