-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bibtex rendering in reports #1001
Conversation
I realized it is only added with sphinx but users probably won't install it.
Fix style issues
remove import
Fix style issues 2
Can we please add @martaarbizu and @martinezeguiluz as contributors? Edit: I'll do it once we merge. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
==========================================
+ Coverage 89.54% 89.61% +0.07%
==========================================
Files 26 26
Lines 3395 3428 +33
Branches 619 625 +6
==========================================
+ Hits 3040 3072 +32
Misses 207 207
- Partials 148 149 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this @eurunuela I noticed that the references are properly rendering at the bottom of the report, but the citations in the "About Tedana" section are still not rendering (see screenshot). Looking at your edits, I'm not sure you directly address the in-text citations. Should that be left for a separate PR or addressed here?
Also, this is minor, but, with the current rendering, it might look nicer with a line of whitespace between each full reference.
The main issue is the citekey for Hunter 2007. I updated the bib file but the tests are still failing but I don't know why. @tsalo @handwerkerd any idea why? |
@eurunuela Does the key for Hunter need to be updated at Edit: Technically the line in |
Ah good catch @notZaki! I forgot we hardcoded the references. Just updated those files. |
@eurunuela I was playing around with it a bit. Sent a PR to your branch. Might fix some stuff, might break other things. 🎲 |
Thank you @notZaki! I didn't really try to optimize the code. It was a quick PR, so thank you for tackling that. I don't have access to my laptop until Sunday. I'll merge then. |
Minor changes/fixes to bibtex rendering
It looks great now, thank you @notZaki! This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you to @eurunuela and @notZaki for isolating and fixing this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it - looks good to me, text seemed to render correctly! nice work per usual
Closes #986
Changes proposed in this pull request:
_bib2html()
that converts the contents of the bibtex file to an HTML string.