Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add bpinsard as a contributor for code #1003

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @bpinsard as a contributor for code.

This was requested by tsalo in this comment

tsalo
tsalo previously approved these changes Nov 22, 2023
eurunuela
eurunuela previously approved these changes Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (d9644ed) to head (c5a2676).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          26       26           
  Lines        3420     3420           
  Branches      624      624           
=======================================
  Hits         3059     3059           
  Misses        210      210           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@handwerkerd handwerkerd dismissed stale reviews from eurunuela and tsalo via 794b23d December 19, 2023 21:44
@handwerkerd
Copy link
Member

@tsalo I think I resolved the merge conflict here, but it's unhappy with the 3.12 unit tests (probably because this PR was created before we updated to allowing 3.12). Any clue how to fix this? Is there a way to have the all-contributors bot generate a new PR and then just close this one?

@handwerkerd
Copy link
Member

Syncing with Main and re-running tests resolved the previous CI failure

@handwerkerd
Copy link
Member

This is really minor and I assume I can merge with only one review. If @tsalo, @eurunuela, or someone else doesn't skim this and approve by Wednesday, I'll just merge.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@handwerkerd handwerkerd merged commit f2a8325 into main Jan 22, 2024
16 checks passed
@handwerkerd handwerkerd deleted the all-contributors/add-bpinsard branch January 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants