-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add bpinsard as a contributor for code #1003
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 26 26
Lines 3420 3420
Branches 624 624
=======================================
Hits 3059 3059
Misses 210 210
Partials 151 151 ☔ View full report in Codecov by Sentry. |
@tsalo I think I resolved the merge conflict here, but it's unhappy with the 3.12 unit tests (probably because this PR was created before we updated to allowing 3.12). Any clue how to fix this? Is there a way to have the all-contributors bot generate a new PR and then just close this one? |
Syncing with Main and re-running tests resolved the previous CI failure |
This is really minor and I assume I can merge with only one review. If @tsalo, @eurunuela, or someone else doesn't skim this and approve by Wednesday, I'll just merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds @bpinsard as a contributor for code.
This was requested by tsalo in this comment