Remove accepted and rejected time series from the standard file outputs and change denoised time series name (updated) #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into Fix-time-series
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 89.54% 89.55% +0.01%
==========================================
Files 26 26
Lines 3462 3466 +4
Branches 632 634 +2
==========================================
+ Hits 3100 3104 +4
Misses 210 210
Partials 152 152 ☔ View full report in Codecov by Sentry. |
doc correction Co-authored-by: Taylor Salo <tsalo90@gmail.com>
eurunuela
approved these changes
Feb 20, 2024
tsalo
approved these changes
Feb 20, 2024
|
@all-contributors please add @martaarbizu for code |
|
I've put up a pull request to add @martaarbizu! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #819. Closes #1006.
This is an update to #1006 by @martaarbizu that includes changes to the docstrings describing the changed output file names.
Changes proposed in this pull request:
Removing files that were previously saved by default is a breaking change and renaming saved files is also a breaking change.