Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --masktype option to control adaptive mask method #1057

Merged
merged 29 commits into from
Apr 8, 2024
Merged

Add --masktype option to control adaptive mask method #1057

merged 29 commits into from
Apr 8, 2024

Commits on Mar 10, 2024

  1. Remove getsum parameter.

    @tsalo
    tsalo committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    5683d32 View commit details
    Browse the repository at this point in the history

  2. Keep removing.

    @tsalo
    tsalo committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    772620e View commit details
    Browse the repository at this point in the history

  3. Add decreasing-signal-based adaptive mask.

    @tsalo
    tsalo committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    9b852bd View commit details
    Browse the repository at this point in the history

  4. Update test.

    @tsalo
    tsalo committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    b595dff View commit details
    Browse the repository at this point in the history

  5. Improve docstring.

    @tsalo
    tsalo committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    bb1eb79 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Update tedana/utils.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ac4114e View commit details
    Browse the repository at this point in the history

  2. Expand on logic of first adaptive mask method.

    @tsalo
    tsalo committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    8f5bda2 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Merge remote-tracking branch 'upstream/main' into fix-adaptive-mask

    @tsalo
    tsalo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    b037d6c View commit details
    Browse the repository at this point in the history

  2. Add masktype option.

    @tsalo
    tsalo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ca8c1b9 View commit details
    Browse the repository at this point in the history

  3. Update utils.py

    @tsalo
    tsalo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ae59d8b View commit details
    Browse the repository at this point in the history

  4. Add "none" option.

    @tsalo
    tsalo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    ce618b3 View commit details
    Browse the repository at this point in the history

  5. Make dropout (old behavior) the default.

    @tsalo
    tsalo committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    33c4c34 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Update utils.py

    @tsalo
    tsalo committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    a7b5cb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Improve test.

    @tsalo
    tsalo committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    823aa5c View commit details
    Browse the repository at this point in the history

  2. Fix.

    @tsalo
    tsalo committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c02b9d9 View commit details
    Browse the repository at this point in the history

  3. Update test_utils.py

    @tsalo
    tsalo committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e7b29a1 View commit details
    Browse the repository at this point in the history

  4. Update test_utils.py

    @tsalo
    tsalo committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    2432f3e View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. Update test_utils.py

    @tsalo
    tsalo committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e356347 View commit details
    Browse the repository at this point in the history

  2. Try updating RTD Python version.

    @tsalo
    tsalo committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    7a8d7bd View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    116480c View commit details
    Browse the repository at this point in the history

  2. Update docstring.

    @tsalo
    tsalo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9973e45 View commit details
    Browse the repository at this point in the history

  3. Replace "none" adaptive mask with base one.

    @tsalo
    tsalo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8e1dd4e View commit details
    Browse the repository at this point in the history

  4. Update test_integration.py

    @tsalo
    tsalo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4eb3c8f View commit details
    Browse the repository at this point in the history

  5. Update utils.py

    @tsalo
    tsalo committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ff863fb View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Update tedana/utils.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    386178f View commit details
    Browse the repository at this point in the history

  2. Update tedana/workflows/t2smap.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    8da1e22 View commit details
    Browse the repository at this point in the history

  3. Update tedana/workflows/tedana.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    bb5c947 View commit details
    Browse the repository at this point in the history

  4. Update tedana/utils.py 

    Co-authored-by: Dan Handwerker <7406227+handwerkerd@users.noreply.github.com>
    @tsalo @handwerkerd
    tsalo and handwerkerd authored Apr 5, 2024
    Configuration menu
    Copy the full SHA
    783bd01 View commit details
    Browse the repository at this point in the history

  5. Update utils.py

    @tsalo
    tsalo committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a0d5f79 View commit details
    Browse the repository at this point in the history