-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor gscontrol
module
#1086
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
- Coverage 89.91% 89.87% -0.05%
==========================================
Files 26 26
Lines 3621 3634 +13
Branches 629 632 +3
==========================================
+ Hits 3256 3266 +10
- Misses 214 216 +2
- Partials 151 152 +1 ☔ View full report in Codecov by Sentry. |
data_cat_nogs : (S x E x T) array_like | ||
Input ``data_cat`` with global signal removed from time series. | ||
data_optcom_nogs : (S x T) array_like | ||
Input ``data_optcom`` with global signal removed from time series. | ||
""" | ||
LGR.info("Applying amplitude-based T1 equilibration correction") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't write the original function, but this looks fine to me.
Closes #1085 (but perhaps not optimally?)
Changes proposed in this pull request:
gscontrol.gscontrol_raw
andgscontrol.minimum_image_regression
.data_cat
instead ofcatd
.verbose
parameter togscontrol.minimum_image_regression
. Only write out the accepted MIR outputs ifverbose=True
.minimum_image_regression
, use classification tags to split up accepted components into BOLD-like and low-variance groups, to match the old "accepted" and "ignored" classifications.