-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Update documentation for interacting with other pipelines #134
Conversation
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 48.72% 48.72%
=======================================
Files 32 32
Lines 2079 2079
=======================================
Hits 1013 1013
Misses 1066 1066 Continue to review full report at Codecov.
|
It looks like you've started the list of what preprocessing is required. I've sketched out my thought's below. I think it might be useful to separate current best practice from things that might matter, but haven't been tested. I'm sure I'm missing something obvious. Main principles:
Acceptable steps before tedana include slice timing correction, despiking, motion correction, & spatial alignment. Things that might matter:
|
Are there also recommendations for post-denoising processing steps? E.g., don't do bandpass filtering, do distortion correction and normalization after (but not before) denoising, etc. |
Trying to catch up on some comments here. I'm not sure there are definitive answers to @tsalo's questions from 2 weeks ago. I don't see any inherent problem with bandpass filtering after denoising. As commented elsewhere distortion correction is theoretically possible anywhere, but if it's done before denoising, it should be done in a way that preserves the raw magnitudes within voxels across all echoes. I'm not sure if any aggressive distortion correction pipeline has really validated this yet, but it should be possible. |
1d2b0ae
to
2dd317b
Compare
I decided to convert this section to our general recommendations for preparing ME-EPI data for |
2dd317b
to
8b64ff0
Compare
8b64ff0
to
4807ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It would be nice to have something that concisely summarizes how preprocessing should be split around tedana, but it's not necessary.
Ok, I think I'm going to merge this ! We can always revisit later to add details. |
Closes #112.
Changes proposed in this pull request:
usage.rst
to reference this new section