Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add Support page #150

Merged
merged 6 commits into from
Nov 1, 2018
Merged

[DOC] Add Support page #150

merged 6 commits into from
Nov 1, 2018

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 1, 2018

Closes #147. We can wait to merge this until #142 is merged, but it's ready for review now.

Changes proposed in this pull request:

  • Add "Support and Communication" page with links to Issues and NeuroStars.
  • Move "Getting Involved" section from "Installation" page to "Contributing" page.
  • Reorder pages on sidebar to better match fMRIPrep's example.

@tsalo tsalo changed the title [DOC, WIP] Add Support page [WIP, DOC] Add Support page Nov 1, 2018
@emdupre
Copy link
Member

emdupre commented Nov 1, 2018

Ok, I just merged #142 ! 🚀

docs/support.rst Outdated
@@ -0,0 +1,10 @@
Support and Communication
-------------------------
All bugs, concerns and enhancement requests for this software can be submitted here: https://github.com/poldracklab/fmriprep/issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an old link ! 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Should be fixed now.

@tsalo tsalo changed the title [WIP, DOC] Add Support page [DOC] Add Support page Nov 1, 2018
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   48.67%   48.67%           
=======================================
  Files          32       32           
  Lines        2077     2077           
=======================================
  Hits         1011     1011           
  Misses       1066     1066

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd034a5...73cf8c8. Read the comment docs.

@@ -1,3 +1,19 @@
Getting involved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pull this out ? It's a good reminder for me, though, to update index.rst...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @tsalo offline and removed this

@emdupre
Copy link
Member

emdupre commented Nov 1, 2018

Looks great ! I had one request but if it's easier I'll just pull it out myself. I just know a merging conflict is brewing 😆

@emdupre emdupre merged commit df0b92f into ME-ICA:master Nov 1, 2018
@tsalo tsalo deleted the support branch November 6, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants