-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Propagate TR to ref_image header #207
Conversation
Travis is unhappy with that extra '1', unsurprisingly. Though I will admit this is the first time I have ever encountered continuous integration.
|
This looks good. Thank you! It looks like you'll just need to update the test. You just need to change Could you also check to see if the 3D images being written out are still 3D? I just want to make sure that they aren't written out with a singleton fourth dimension. Lastly, could you add the [FIX] prefix to this PR title and remove the [bug] one from the corresponding issue? |
3dinfo reports that dn_ts_OC.nii has a time dimension, with the correct tr, whereas s0v.nii has no time dimension. Opens fine in AFNI as well. Let me know if you want another check of that. |
If it has no time dimension then I think that should be fine. Thank you for checking! |
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
=======================================
Coverage 51.42% 51.42%
=======================================
Files 32 32
Lines 1964 1964
=======================================
Hits 1010 1010
Misses 954 954
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for catching this, @dowdlelt.
I'll go ahead and merge, then ! Thanks @dowdlelt ✨ |
Closes #206 .
Changes proposed in this pull request: