Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] scatter plot labeling issue. #235

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Conversation

dowdlelt
Copy link
Collaborator

@dowdlelt dowdlelt commented Mar 11, 2019

Closes #234

Changes proposed in this pull request:

  • change to label=kind, such that the label with match the dictionary. Should work even if we add new things to dictionary.
  • midk removed from scatter dictionary

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #235 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   47.83%   47.19%   -0.65%     
==========================================
  Files          33       32       -1     
  Lines        2013     1977      -36     
==========================================
- Hits          963      933      -30     
+ Misses       1050     1044       -6
Impacted Files Coverage Δ
tedana/viz.py 9% <ø> (ø) ⬆️
tedana/decomposition/_utils.py 27.77% <0%> (-38.02%) ⬇️
tedana/info.py 100% <0%> (ø) ⬆️
tedana/tests/test_decomposition__utils.py
tedana/workflows/tedana.py 13.92% <0%> (+0.08%) ⬆️
tedana/decomposition/eigendecomp.py 10.58% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c08b8a...6a973e9. Read the comment docs.

@emdupre
Copy link
Member

emdupre commented Mar 11, 2019

LGTM !

@emdupre
Copy link
Member

emdupre commented Mar 11, 2019

With #228 merged in I wonder if the black circle will disappear -- since now we do --tedpca kundu for the three-echo test. I guess we'll find out....

@tsalo
Copy link
Member

tsalo commented Mar 11, 2019

@dowdlelt midk is also a rationale now and not a classification, so you can drop that from the dictionary.

@emdupre emdupre merged commit 2d99a0b into ME-ICA:master Mar 12, 2019
@dowdlelt dowdlelt deleted the scatter_fix branch November 3, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scatter plot labels incorrect
3 participants