[FIX, DOC] Use countnoise in decision table within selcomps #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. In the process of documenting
selcomps
, I realized that I must have made a mistake when I added in table support toselcomps
. Namely, the variablecountnoise
was not being incorporated properly in the decision tables used for certain component selection steps.countnoise
was used properly in other steps, so I think the impact is minimal.Changes proposed in this pull request:
countnoise
variable fromselcomps
. When we switched over to using tables, I forgot to remove this variable, so it was being initialized as an array of zeros but wasn't filled out (because the associated column ofcomptable
was).countnoise
was only used in the decision table steps, so it was essentially being ignored as a metric there.ct_df
variable intedpca
withcomptable
to match package convention.