Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add gscontrol module #240

Merged
merged 2 commits into from
Mar 22, 2019
Merged

[REF] Add gscontrol module #240

merged 2 commits into from
Mar 22, 2019

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 22, 2019

Closes None.

Changes proposed in this pull request:

  • Move gscontrol_raw and gscontrol_mmix into new gscontrol module. They are currently in model.fit and io, respectively, which are not good places for them.

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #240 into master will increase coverage by 0.15%.
The diff coverage is 28.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #240      +/-   ##
=========================================
+ Coverage   46.34%   46.5%   +0.15%     
=========================================
  Files          32      33       +1     
  Lines        2026    2032       +6     
=========================================
+ Hits          939     945       +6     
  Misses       1087    1087
Impacted Files Coverage Δ
tedana/model/__init__.py 100% <ø> (ø) ⬆️
tedana/model/fit.py 28.03% <ø> (+0.32%) ⬆️
tedana/tests/test_gscontrol.py 100% <100%> (ø)
tedana/io.py 47.87% <100%> (+10.27%) ⬆️
tedana/gscontrol.py 22.53% <22.53%> (ø)
tedana/workflows/tedana.py 14.19% <50%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39d1f0...8b784b0. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Mar 22, 2019

Merging now!

@tsalo tsalo merged commit 4187549 into ME-ICA:master Mar 22, 2019
@tsalo tsalo deleted the refactor-gscontrol branch March 23, 2019 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant