Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add early escape from TEDICA decision tree #298

Merged
merged 1 commit into from
May 26, 2019

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented May 25, 2019

Closes #297.

Changes proposed in this pull request:

  • Add early stopping procedure to TEDICA decision for when no potential BOLD components are identified in Step 1.

@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #298 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #298      +/-   ##
=========================================
- Coverage   49.36%   49.2%   -0.17%     
=========================================
  Files          39      39              
  Lines        2133    2140       +7     
=========================================
  Hits         1053    1053              
- Misses       1080    1087       +7
Impacted Files Coverage Δ
tedana/selection/tedica.py 23.52% <0%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0d704...5fce033. Read the comment docs.

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's the same escape as used later for a similar problem, so this is probably the most consistent way to handle it.

@ME-ICA ME-ICA deleted a comment from codecov bot May 26, 2019
@emdupre
Copy link
Member

emdupre commented May 26, 2019

👍 Looks great to me, too ! I think it will at least make it clear to folks what's happened in their dataset.

@tsalo tsalo merged commit 6b87e4f into ME-ICA:master May 26, 2019
@tsalo tsalo deleted the quit-early branch May 26, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component selection breaks when no BOLD components are found
3 participants