-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Add all contributors to Zenodo file #614
Conversation
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 26 26
Lines 1965 1965
=======================================
Hits 1838 1838
Misses 127 127 Continue to review full report at Codecov.
|
Thanks @emdupre.
We're past the October 30th deadline for #612, so I'm marking this PR ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for putting this together @tsalo, and thanks to all of our contributors!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tsalo ! Two quick clarifications on some affiliations that might have updated.
}, | ||
{ | ||
"name": "Whitaker, Kirstie", | ||
"affiliation": "Alan Turing Institute; Cambridge University", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KirstieJane can confirm, but I believe she's currently only affiliated with the Turing (not Cambridge)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to her CV (last updated in January), she's still affiliated with Cambridge.
}, | ||
{ | ||
"name": "Kundu, Prantik", | ||
"affiliation": "Mount Sinai Hospital", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure if he's still affiliated with Mount Sinai. I know that he's now a research head at Hyperfine, so we might want to update his affiliation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we even include affiliations when they change so much in academia? We've got ORCIDs and those are at least stable...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
His CV says he's still at Mount Sinai and Hyperfine, so I think we're good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot find his CV 😅 Is it on LinkedIn ? I always get locked out of LinkedIn profiles since I refuse to make an account....
But thanks for confirming ! Should we add Hyperfine, then ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's linked from his LinkedIn.
Should we add Hyperfine, then ?
Do folks normally include private companies in their affiliations? If so, then I can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to say yes, but I'm having a hard time finding an immediate example. Though if you'd rather leave it off because of the institution-type, I'm fine with that as a guideline for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If he was just affiliated with Hyperfine, then I'd use that, but since he has an academic affiliation as well, I feel like that's enough. There's also an element of laziness, to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, @tsalo ! Very happy to have this (at least, more) up-to-date.
Closes #612.
Changes proposed in this pull request: