Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add all contributors to Zenodo file #614

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 19, 2020

Closes #612.

Changes proposed in this pull request:

  • Add all contributors to Zenodo file.
  • Reorder Zenodo contributors in file alphabetically by last name.

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          26       26           
  Lines        1965     1965           
=======================================
  Hits         1838     1838           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 005e9d9...2b946a0. Read the comment docs.

.zenodo.json Show resolved Hide resolved
@tsalo tsalo marked this pull request as ready for review November 2, 2020 22:38
@tsalo
Copy link
Member Author

tsalo commented Nov 2, 2020

We're past the October 30th deadline for #612, so I'm marking this PR ready for review.

@tsalo tsalo requested review from emdupre and jbteves November 2, 2020 22:38
.zenodo.json Show resolved Hide resolved
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting this together @tsalo, and thanks to all of our contributors!

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tsalo ! Two quick clarifications on some affiliations that might have updated.

},
{
"name": "Whitaker, Kirstie",
"affiliation": "Alan Turing Institute; Cambridge University",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KirstieJane can confirm, but I believe she's currently only affiliated with the Turing (not Cambridge)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to her CV (last updated in January), she's still affiliated with Cambridge.

},
{
"name": "Kundu, Prantik",
"affiliation": "Mount Sinai Hospital",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually not sure if he's still affiliated with Mount Sinai. I know that he's now a research head at Hyperfine, so we might want to update his affiliation ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we even include affiliations when they change so much in academia? We've got ORCIDs and those are at least stable...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

His CV says he's still at Mount Sinai and Hyperfine, so I think we're good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find his CV 😅 Is it on LinkedIn ? I always get locked out of LinkedIn profiles since I refuse to make an account....
But thanks for confirming ! Should we add Hyperfine, then ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's linked from his LinkedIn.

Should we add Hyperfine, then ?

Do folks normally include private companies in their affiliations? If so, then I can do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say yes, but I'm having a hard time finding an immediate example. Though if you'd rather leave it off because of the institution-type, I'm fine with that as a guideline for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If he was just affiliated with Hyperfine, then I'd use that, but since he has an academic affiliation as well, I feel like that's enough. There's also an element of laziness, to be honest.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @tsalo ! Very happy to have this (at least, more) up-to-date.

@tsalo tsalo merged commit 61af3f1 into ME-ICA:master Nov 3, 2020
@tsalo tsalo deleted the zenodo-update branch November 3, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all contributors to Zenodo file
3 participants