Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Allow CI for all-contributors #627

Merged
merged 1 commit into from
Dec 7, 2020
Merged

[TST] Allow CI for all-contributors #627

merged 1 commit into from
Dec 7, 2020

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Dec 7, 2020

Closes #628

Changes proposed in this pull request:

  • Deploys CI for all-contributors so we can review it like normal pull requests

@jbteves jbteves changed the title Allow CI for all-contributors [TST] Allow CI for all-contributors Dec 7, 2020
@tsalo
Copy link
Member

tsalo commented Dec 7, 2020

This seems like a reasonable change. I will approve once tests pass. Can we close and re-request #626 once this is merged as a test?

@jbteves
Copy link
Collaborator Author

jbteves commented Dec 7, 2020

I'm fine with that. The other thought is that we may want to add credit for bringing to our attention this potential difference in results from different python versions. But that may cause some weirdness on the bot's branch.

@tsalo
Copy link
Member

tsalo commented Dec 7, 2020

Okay, good point. So maybe instead we merge #626 and then make a new request for the bug report once we have an issue for the Python version weirdness.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #627 (5ba4781) into master (c121195) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          26       26           
  Lines        1967     1967           
=======================================
  Hits         1840     1840           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c121195...5ba4781. Read the comment docs.

@handwerkerd
Copy link
Member

It would be nicer to have a way to avoid testing the code every time we make a documentation change, but, currently, this seems like a reasonable solution.

@jbteves jbteves merged commit b4a58c8 into master Dec 7, 2020
@jbteves jbteves deleted the allowCI branch December 7, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow CI for all-contributors
4 participants