Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Clarify role of components in docs #660

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

notZaki
Copy link
Contributor

@notZaki notZaki commented Jan 26, 2021

Closes #634

@notZaki notZaki changed the title Clarify role of components in docs [DOC] Clarify role of components in docs Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #660 (8773228) into master (5369e1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #660   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files          26       26           
  Lines        1975     1975           
=======================================
  Hits         1848     1848           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5369e1d...8773228. Read the comment docs.

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this will clarify things nicely for new users.
Thanks @notZaki !

@jbteves
Copy link
Collaborator

jbteves commented Jan 26, 2021

@all-contributors add @notZaki for documentation.

@allcontributors
Copy link
Contributor

@jbteves

I've put up a pull request to add @notZaki! 🎉

@jbteves jbteves merged commit 1e7d42f into ME-ICA:master Jan 26, 2021
@notZaki notZaki deleted the compdesc branch March 19, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role of ignored components is ambiguous in docs
3 participants