[ENH] Allow tedpca argument to be a float inside a string #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a much cleaner approach. It looks like there are style issues that need to be addressed and I might have some changes to the whitespace to request, but overall this looks great! |
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
- Coverage 93.75% 93.75% -0.01%
==========================================
Files 26 26
Lines 2019 2017 -2
==========================================
- Hits 1893 1891 -2
Misses 126 126
Continue to review full report at Codecov.
|
tsalo
requested changes
Jan 28, 2021
eurunuela
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes none.
Got a parser error while trying the variance-based PCA introduced in #658.
I think it's because the inputs to
workflows.tedana.main_are strings but the parser treats"0.95"as an invalid input.This PR modifies
workflows.parser_utils.check_tedpca_valueto accept floats-inside-strings. The function got refactored a bit while I was debugging.