Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add references to HTML report #695

Merged
merged 1 commit into from
Mar 22, 2021
Merged

[DOC] Add references to HTML report #695

merged 1 commit into from
Mar 22, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 9, 2021

Closes #686.

Changes proposed in this pull request:

  • Generate HTML reports after the text is cleaned up and references are added to report.txt. This results in the references being included in HTML reports.

@tsalo tsalo changed the title [DOC] Add references to HTML workflow [DOC] Add references to HTML report Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #695 (8fd2c61) into main (956e01d) will not change coverage.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #695   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files          26       26           
  Lines        2029     2029           
=======================================
  Hits         1900     1900           
  Misses        129      129
Impacted Files Coverage Δ
tedana/workflows/tedana.py 89.82% <81.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956e01d...8fd2c61. Read the comment docs.

@tsalo tsalo requested review from jbteves and emdupre March 16, 2021 14:46
jbteves
jbteves approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tsalo !

@handwerkerd handwerkerd self-requested a review March 22, 2021 20:14
handwerkerd
handwerkerd approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good... I also realized I put my one comment on the issue rather than this PR.

@tsalo tsalo merged commit 170422e into ME-ICA:main Mar 22, 2021
@tsalo tsalo deleted the report-references branch March 22, 2021 22:03
tsalo added a commit to tsalo/tedana that referenced this pull request Jun 17, 2021
@tsalo
Reimplement ME-ICA#695.
f3b9551
@tsalo tsalo mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbteves jbteves jbteves approved these changes

@handwerkerd handwerkerd handwerkerd approved these changes

@emdupre emdupre Awaiting requested review from emdupre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add references to HTML reports
3 participants
@tsalo @handwerkerd @jbteves