Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sphinx functions to fix building error for docs #727

Merged
merged 3 commits into from
May 21, 2021
Merged

Rename sphinx functions to fix building error for docs #727

merged 3 commits into from
May 21, 2021

Conversation

eurunuela
Copy link
Collaborator

Closes #726 .

Changes proposed in this pull request:

  • Renames two sphinx functions that have been renamed (probably after an update).

@eurunuela eurunuela added documentation issues related to improving documentation for the project priority: high issues that would be really helpful if they were fixed already effort: low Theoretically less than a day's work impact: high Enhancement or functionality improvement that will affect most users maintenance issues related to versioning, dependencies, and other related elements labels May 15, 2021
@codecov
Copy link

codecov bot commented May 15, 2021 •
edited
Loading

Codecov Report

Merging #727 (fee8b48) into main (ad664ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files          25       25           
  Lines        1879     1879           
=======================================
  Hits         1744     1744           
  Misses        135      135

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad664ae...fee8b48. Read the comment docs.

@jbteves
Copy link
Collaborator

jbteves commented May 18, 2021

@eurunuela do you mind sending a patch where you don't auto-format so we can see changes only related to build? Though it looks like pretty much everyone is using black at this point, so might be worth discussing on Friday.

@eurunuela
Copy link
Collaborator Author

I'm sorry about that @jbteves . I've started using emacs and I've got it set up so that it automatically formats in black when I save the file. I'll make the changes!

Re Friday: I'm not sure I'll make it.

@eurunuela
Copy link
Collaborator Author

You should only see non-style changes now @jbteves . Thanks for pointing it out!

jbteves
jbteves approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @eurunuela !

@jbteves jbteves merged commit e1bfc01 into ME-ICA:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handwerkerd handwerkerd handwerkerd approved these changes

@jbteves jbteves jbteves approved these changes

@emdupre emdupre Awaiting requested review from emdupre

Assignees
No one assigned
Labels
documentation issues related to improving documentation for the project effort: low Theoretically less than a day's work impact: high Enhancement or functionality improvement that will affect most users maintenance issues related to versioning, dependencies, and other related elements priority: high issues that would be really helpful if they were fixed already
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs fail to build
3 participants
@eurunuela @jbteves @handwerkerd