Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correct manacc documentation and check for associated inputs #754

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jul 15, 2021

Closes #753.

Changes proposed in this pull request:

  • Describe mutually dependent parameters in argument parser and workflow docstring.
  • Check that both ctab and mmix are provided if manacc is, rather than just checking for mmix.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #754 (6d5bdb1) into main (319bbba) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          27       27           
  Lines        2121     2121           
=======================================
  Hits         1964     1964           
  Misses        157      157           
Impacted Files Coverage Δ
tedana/workflows/tedana.py 90.30% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319bbba...6d5bdb1. Read the comment docs.

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tsalo ! I fiddled around with trying to make things required via argparse, but you don't get as informative of error messages. The only upside would be that the parser fails much faster than loading the images and then checking some of these args, so I think your implementation is a better trade-off!

@tsalo
Copy link
Member Author

tsalo commented Jul 16, 2021

Thanks @jbteves and @eurunuela.

@jbteves, yeah that seems like an unfortunate gap in argparse.

@tsalo tsalo merged commit d2c9e84 into ME-ICA:main Jul 16, 2021
@tsalo tsalo deleted the manacc-docs branch July 16, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manacc documentation and validation is incorrect
3 participants