Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add fMRIPrep collection information to FAQ #773

Merged
merged 6 commits into from
Sep 2, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 18, 2021

Closes #717.

Changes proposed in this pull request:

  • Add information about collecting fMRIPrep data (with gist) to FAQ.
  • Link to new FAQ in other sections.

@tsalo
Copy link
Member Author

tsalo commented Aug 18, 2021

I cancelled almost all of the jobs because this is a docs PR. Can restart later as long as the RTD test looks good.

@tsalo
Copy link
Member Author

tsalo commented Aug 18, 2021

It looks great, but if anyone knows how to limit the embedded window to a certain number of lines (like how it is with permalinks in GitHub issues/PRs), that would be awesome.

image

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #773 (28050e9) into main (3147e01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files          27       27           
  Lines        2209     2209           
=======================================
  Hits         2059     2059           
  Misses        150      150           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3147e01...28050e9. Read the comment docs.

eurunuela
eurunuela previously approved these changes Aug 19, 2021
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @tsalo

@dowdlelt
Copy link
Collaborator

Maybe have something that points to the original issue, #717 so that when this closes it, and it (inevitably?) breaks, people could quickly reopen this.

@tsalo
Copy link
Member Author

tsalo commented Aug 19, 2021

Thanks @dowdlelt. Added in b9209f0.

eurunuela
eurunuela previously approved these changes Aug 19, 2021
docs/faq.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you @tsalo !

@tsalo tsalo requested a review from jbteves August 31, 2021 20:42
Copy link
Collaborator

@jbteves jbteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @tsalo ! It looks particularly nice to have the gist embedded, awesome.

@tsalo tsalo merged commit ab7afd8 into ME-ICA:main Sep 2, 2021
@tsalo tsalo deleted the fmriprep-gist branch September 2, 2021 14:42
@AaronAngJW
Copy link

Hi there,

Is there any possibility of adding a couple more information as to how to properly use this collect_fmriprep.py function?

  • When exactly do you call this process in the script?
  • What to expect if the function was ran successfully?
  • How to then integrate the output of this function onto the actual tedana process.

It'd be really really nice if we can even get some sort of graphical guide that could aid this process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information about extracting echo-wise preprocessed data from fMRIPrep to FAQ
5 participants