[FIX] Figures of components with index 0 get rendered now #793
Conversation
eurunuela
added
the
reports
Codecov Report
@@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 27 27
Lines 2208 2209 +1
=======================================
+ Hits 2058 2059 +1
Misses 150 150
Continue to review full report at Codecov.
|
|
To be honest the diff from the auto formatting is making it hard to see what the meaningful changes were. Could you add in a couple of GitHub comments to point to the affected code? |
There was a problem hiding this comment.
After sharing a couple of emails with angharaddecates from Neurostars we have found out that reports generated with Bokeh v2.3 or higher won't render at all. I've just added this constraint to info.py in c4bebb1 .
|
|
||
| tap_callback_jscode = """ | ||
| // Accessing the selected component ID | ||
| var data = source_comp_table.data; | ||
| var selected_idx = source_comp_table.selected.indices; | ||
| if(selected_idx > 0) { | ||
| console.log('Selected idx is ' + selected_idx) | ||
| if(selected_idx >= 0) { |
There was a problem hiding this comment.
@tsalo This is the main contribution for what I recall.
Done! I had completely forgotten about it, thank you @tsalo ! I'll merge once the tests pass. |
|
I don't know what's wrong with the 3-echo test... it keeps hanging up... Given that this PR does NOT add anything that could conflict with the test, I'll merge. Edit: I actually cannot merge 🤣 I've re-sent the job to run the 3-echo test, hopefully it will work now. |
|
Hm, we just had the same thing happen with |
|
Can someone with admin permissions merge so we can release? We can fix it in a different PR. |
|
Sure, I'll push it through. We should open an issue about the three-echo problem though. |
Closes #766 .
Changes proposed in this pull request: