Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add 3.10 unit test, compatibilities in setup.cfg #818

Merged
merged 8 commits into from
Nov 22, 2022
Merged

[MAINT] Add 3.10 unit test, compatibilities in setup.cfg #818

merged 8 commits into from
Nov 22, 2022

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Oct 15, 2021

Closes #817 .

Changes proposed in this pull request:

  • Adds 3.10 Support, testing

@jbteves jbteves changed the title Add 3.10 unit test, compatibilities in info.py [MAINT[ Add 3.10 unit test, compatibilities in info.py Oct 15, 2021
@jbteves jbteves changed the title [MAINT[ Add 3.10 unit test, compatibilities in info.py [MAINT] Add 3.10 unit test, compatibilities in info.py Oct 15, 2021
@tsalo
Copy link
Member

tsalo commented Oct 15, 2021

In NiMARE trying out Python 3.10 failed. I don't even know what's happening here... Why would it freeze like that?

@jbteves
Copy link
Collaborator Author

jbteves commented Oct 15, 2021

It appears it was trying to download many copies of many packages... I'm not sure. I'm willing to wait a bit and simply push a blank commit to see if it is resolved in perhaps a month.

@tsalo
Copy link
Member

tsalo commented Nov 16, 2021

It looks like v1.21.4 supports 3.10.

@handwerkerd
Copy link
Member

It looks like SciPy 1.8 may now support Python 3.10. Worth confirming? https://docs.scipy.org/doc/scipy/release.1.8.0.html

@jbteves
Copy link
Collaborator Author

jbteves commented Feb 17, 2022

No dice.

@tsalo
Copy link
Member

tsalo commented Aug 12, 2022

I think this might be worth another check. Can you update from main?

@jbteves
Copy link
Collaborator Author

jbteves commented Nov 16, 2022

Finally passes, now that we have 3.11!

@jbteves jbteves changed the title [MAINT] Add 3.10 unit test, compatibilities in info.py [MAINT] Add 3.10 unit test, compatibilities in setup.cfg Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 93.30% // Head: 93.30% // No change to project coverage 👍

Coverage data is based on head (11f3224) compared to base (0879a94).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          28       28           
  Lines        2345     2345           
=======================================
  Hits         2188     2188           
  Misses        157      157           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

setup.cfg Outdated Show resolved Hide resolved
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jbteves jbteves merged commit d85dac3 into ME-ICA:main Nov 22, 2022
@jbteves jbteves deleted the add_3_10 branch November 22, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 Support
4 participants