Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Switch to setup.cfg-based configuration #874

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Apr 28, 2022

Closes #872.

Changes proposed in this pull request:

  • Delete tedana/info.py and move its contents into setup.cfg.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #874 (01212cb) into main (40ee322) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #874   +/-   ##
=======================================
  Coverage   93.10%   93.11%           
=======================================
  Files          27       27           
  Lines        2219     2221    +2     
=======================================
+ Hits         2066     2068    +2     
  Misses        153      153           
Impacted Files Coverage Δ
tedana/__init__.py 100.00% <100.00%> (ø)
tedana/reporting/html_report.py 100.00% <100.00%> (ø)
tedana/workflows/tedana.py 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ee322...01212cb. Read the comment docs.

@tsalo tsalo requested a review from jbteves April 28, 2022 19:15
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo
Copy link
Member Author

tsalo commented Apr 29, 2022

Thanks @jbteves and @eurunuela! I'll merge now.

@tsalo tsalo merged commit 50f21ab into ME-ICA:main Apr 29, 2022
@tsalo tsalo deleted the setup branch April 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINT] Change setup configuration
3 participants