[FIX] Use capital names in desc-ICAOrth_mixing.tsv columns #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… following the nomenclature in other .tsv files
Codecov ReportBase: 93.30% // Head: 93.30% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 28 28
Lines 2345 2345
=======================================
Hits 2188 2188
Misses 157 157
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
eurunuela
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Thank you for your contribution @pablosmig!
The changes LGTM.
eurunuela
changed the title
|
LGTM, thanks @pablosmig ! |
jbteves
approved these changes
Nov 23, 2022
|
@jbteves: could you please add @pablosmig as a contributor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes isue #904 to write the
desc-ICAOrth_mixing.tsvwith the ICA column prefix in capital letters as in the other matrices.[FIX]
Closes #904
Changes proposed in this pull request: