Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Remove Josh as maintainer #928

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[DOC] Remove Josh as maintainer #928

merged 2 commits into from
Feb 16, 2023

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Jan 31, 2023

Closes None .

Changes proposed in this pull request:

  • Removes my status as maintainer, steering committee member, collaborative programming lead, and communications leader.

Thanks for all of the good times!

@handwerkerd
Copy link
Member

I have many concerns about this PR. It might take a long while to read carefully and ponder the full implications of this PR before I am willing to approve it.

@eurunuela
Copy link
Collaborator

I have many concerns about this PR. It might take a long while to read carefully and ponder the full implications of this PR before I am willing to approve it.

Well, the PR is going to take a bit longer than expected because unit tests are not passing... Seems like some kind of change in a new numpy version?

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 93.30% // Head: 93.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (23bd65e) compared to base (f00cb25).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files          28       28           
  Lines        2345     2346    +1     
=======================================
+ Hits         2188     2189    +1     
  Misses        157      157           
Impacted Files Coverage Δ
tedana/io.py 94.00% <ø> (ø)
tedana/selection/_utils.py 100.00% <100.00%> (ø)
tedana/selection/tedica.py 91.55% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look good to me, but still approving.

@handwerkerd handwerkerd merged commit fb6e255 into ME-ICA:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants